Commit e6364cd3 authored by Linus Torvalds's avatar Linus Torvalds

Merge git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-2.6

* git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-2.6:
  modules: do not try to add sysfs attributes if !CONFIG_SYSFS
  POWERPC: fix typo in pseries/power.c
  PM: Remove unbalanced mutex_unlock() from dpm_resume()
  UIO: fix Greg's stupid changes
  stable_kernel_rules: fix must already be in mainline
  ide: mark "ide=reverse" option as obsolete
  Driver core: Fix error handling in bus_add_driver().
  driver-core: fix kernel-doc function parameters
  cpufreq: fix kobject reference count handling
  slabinfo: fall back from /sys/kernel/slab to /sys/slab
  Fix broken utf-8 encodings in ja_JP translation of stable_kernel_rules.txt
parents b8967d88 120fc3d7
This diff is collapsed.
...@@ -16,8 +16,9 @@ Rules on what kind of patches are accepted, and which ones are not, into the ...@@ -16,8 +16,9 @@ Rules on what kind of patches are accepted, and which ones are not, into the
race can be exploited is also provided. race can be exploited is also provided.
- It cannot contain any "trivial" fixes in it (spelling changes, - It cannot contain any "trivial" fixes in it (spelling changes,
whitespace cleanups, etc). whitespace cleanups, etc).
- It must be accepted by the relevant subsystem maintainer.
- It must follow the Documentation/SubmittingPatches rules. - It must follow the Documentation/SubmittingPatches rules.
- It or an equivalent fix must already exist in Linus' tree. Quote the
respective commit ID in Linus' tree in your patch submission to -stable.
Procedure for submitting patches to the -stable tree: Procedure for submitting patches to the -stable tree:
...@@ -28,7 +29,9 @@ Procedure for submitting patches to the -stable tree: ...@@ -28,7 +29,9 @@ Procedure for submitting patches to the -stable tree:
queue, or a NAK if the patch is rejected. This response might take a few queue, or a NAK if the patch is rejected. This response might take a few
days, according to the developer's schedules. days, according to the developer's schedules.
- If accepted, the patch will be added to the -stable queue, for review by - If accepted, the patch will be added to the -stable queue, for review by
other developers. other developers and by the relevant subsystem maintainer.
- If the stable@kernel.org address is added to a patch, when it goes into
Linus's tree it will automatically be emailed to the stable team.
- Security patches should not be sent to this alias, but instead to the - Security patches should not be sent to this alias, but instead to the
documented security@kernel.org address. documented security@kernel.org address.
......
...@@ -1123,7 +1123,7 @@ void read_slab_dir(void) ...@@ -1123,7 +1123,7 @@ void read_slab_dir(void)
char *t; char *t;
int count; int count;
if (chdir("/sys/kernel/slab")) if (chdir("/sys/kernel/slab") && chdir("/sys/slab"))
fatal("SYSFS support for SLUB not active\n"); fatal("SYSFS support for SLUB not active\n");
dir = opendir("."); dir = opendir(".");
......
...@@ -658,9 +658,10 @@ int bus_add_driver(struct device_driver *drv) ...@@ -658,9 +658,10 @@ int bus_add_driver(struct device_driver *drv)
pr_debug("bus: '%s': add driver %s\n", bus->name, drv->name); pr_debug("bus: '%s': add driver %s\n", bus->name, drv->name);
priv = kzalloc(sizeof(*priv), GFP_KERNEL); priv = kzalloc(sizeof(*priv), GFP_KERNEL);
if (!priv) if (!priv) {
return -ENOMEM; error = -ENOMEM;
goto out_put_bus;
}
klist_init(&priv->klist_devices, NULL, NULL); klist_init(&priv->klist_devices, NULL, NULL);
priv->driver = drv; priv->driver = drv;
drv->p = priv; drv->p = priv;
...@@ -668,7 +669,7 @@ int bus_add_driver(struct device_driver *drv) ...@@ -668,7 +669,7 @@ int bus_add_driver(struct device_driver *drv)
error = kobject_init_and_add(&priv->kobj, &driver_ktype, NULL, error = kobject_init_and_add(&priv->kobj, &driver_ktype, NULL,
"%s", drv->name); "%s", drv->name);
if (error) if (error)
goto out_put_bus; goto out_unregister;
if (drv->bus->p->drivers_autoprobe) { if (drv->bus->p->drivers_autoprobe) {
error = driver_attach(drv); error = driver_attach(drv);
......
...@@ -120,6 +120,9 @@ EXPORT_SYMBOL_GPL(driver_remove_file); ...@@ -120,6 +120,9 @@ EXPORT_SYMBOL_GPL(driver_remove_file);
/** /**
* driver_add_kobj - add a kobject below the specified driver * driver_add_kobj - add a kobject below the specified driver
* @drv: requesting device driver
* @kobj: kobject to add below this driver
* @fmt: format string that names the kobject
* *
* You really don't want to do this, this is only here due to one looney * You really don't want to do this, this is only here due to one looney
* iseries driver, go poke those developers if you are annoyed about * iseries driver, go poke those developers if you are annoyed about
......
...@@ -479,7 +479,6 @@ static int dpm_suspend(pm_message_t state) ...@@ -479,7 +479,6 @@ static int dpm_suspend(pm_message_t state)
mutex_lock(&dpm_list_mtx); mutex_lock(&dpm_list_mtx);
if (list_empty(&dev->power.entry)) if (list_empty(&dev->power.entry))
list_add(&dev->power.entry, &dpm_locked); list_add(&dev->power.entry, &dpm_locked);
mutex_unlock(&dpm_list_mtx);
break; break;
} }
mutex_lock(&dpm_list_mtx); mutex_lock(&dpm_list_mtx);
...@@ -523,6 +522,7 @@ static void lock_all_devices(void) ...@@ -523,6 +522,7 @@ static void lock_all_devices(void)
/** /**
* device_suspend - Save state and stop all devices in system. * device_suspend - Save state and stop all devices in system.
* @state: new power management state
* *
* Prevent new devices from being registered, then lock all devices * Prevent new devices from being registered, then lock all devices
* and suspend them. * and suspend them.
......
...@@ -1006,14 +1006,6 @@ static int __cpufreq_remove_dev (struct sys_device * sys_dev) ...@@ -1006,14 +1006,6 @@ static int __cpufreq_remove_dev (struct sys_device * sys_dev)
} }
#endif #endif
if (!kobject_get(&data->kobj)) {
spin_unlock_irqrestore(&cpufreq_driver_lock, flags);
cpufreq_debug_enable_ratelimit();
unlock_policy_rwsem_write(cpu);
return -EFAULT;
}
#ifdef CONFIG_SMP #ifdef CONFIG_SMP
#ifdef CONFIG_HOTPLUG_CPU #ifdef CONFIG_HOTPLUG_CPU
......
...@@ -1229,7 +1229,7 @@ static int __init ide_setup(char *s) ...@@ -1229,7 +1229,7 @@ static int __init ide_setup(char *s)
if (!strcmp(s, "ide=reverse")) { if (!strcmp(s, "ide=reverse")) {
ide_scan_direction = 1; ide_scan_direction = 1;
printk(" : Enabled support for IDE inverse scan order.\n"); printk(" : Enabled support for IDE inverse scan order.\n");
return 1; goto obsolete_option;
} }
#endif #endif
......
...@@ -57,29 +57,29 @@ struct uio_map { ...@@ -57,29 +57,29 @@ struct uio_map {
}; };
#define to_map(map) container_of(map, struct uio_map, kobj) #define to_map(map) container_of(map, struct uio_map, kobj)
static ssize_t map_addr_show(struct uio_mem *mem, char *buf)
static ssize_t map_attr_show(struct kobject *kobj, struct kobj_attribute *attr,
char *buf)
{ {
struct uio_map *map = to_map(kobj); return sprintf(buf, "0x%lx\n", mem->addr);
struct uio_mem *mem = map->mem; }
if (strncmp(attr->attr.name, "addr", 4) == 0)
return sprintf(buf, "0x%lx\n", mem->addr);
if (strncmp(attr->attr.name, "size", 4) == 0)
return sprintf(buf, "0x%lx\n", mem->size);
return -ENODEV; static ssize_t map_size_show(struct uio_mem *mem, char *buf)
{
return sprintf(buf, "0x%lx\n", mem->size);
} }
static struct kobj_attribute attr_attribute = struct uio_sysfs_entry {
__ATTR(addr, S_IRUGO, map_attr_show, NULL); struct attribute attr;
static struct kobj_attribute size_attribute = ssize_t (*show)(struct uio_mem *, char *);
__ATTR(size, S_IRUGO, map_attr_show, NULL); ssize_t (*store)(struct uio_mem *, const char *, size_t);
};
static struct uio_sysfs_entry addr_attribute =
__ATTR(addr, S_IRUGO, map_addr_show, NULL);
static struct uio_sysfs_entry size_attribute =
__ATTR(size, S_IRUGO, map_size_show, NULL);
static struct attribute *attrs[] = { static struct attribute *attrs[] = {
&attr_attribute.attr, &addr_attribute.attr,
&size_attribute.attr, &size_attribute.attr,
NULL, /* need to NULL terminate the list of attributes */ NULL, /* need to NULL terminate the list of attributes */
}; };
...@@ -90,8 +90,28 @@ static void map_release(struct kobject *kobj) ...@@ -90,8 +90,28 @@ static void map_release(struct kobject *kobj)
kfree(map); kfree(map);
} }
static ssize_t map_type_show(struct kobject *kobj, struct attribute *attr,
char *buf)
{
struct uio_map *map = to_map(kobj);
struct uio_mem *mem = map->mem;
struct uio_sysfs_entry *entry;
entry = container_of(attr, struct uio_sysfs_entry, attr);
if (!entry->show)
return -EIO;
return entry->show(mem, buf);
}
static struct sysfs_ops uio_sysfs_ops = {
.show = map_type_show,
};
static struct kobj_type map_attr_type = { static struct kobj_type map_attr_type = {
.release = map_release, .release = map_release,
.sysfs_ops = &uio_sysfs_ops,
.default_attrs = attrs, .default_attrs = attrs,
}; };
......
...@@ -987,12 +987,11 @@ static unsigned long resolve_symbol(Elf_Shdr *sechdrs, ...@@ -987,12 +987,11 @@ static unsigned long resolve_symbol(Elf_Shdr *sechdrs,
return ret; return ret;
} }
/* /*
* /sys/module/foo/sections stuff * /sys/module/foo/sections stuff
* J. Corbet <corbet@lwn.net> * J. Corbet <corbet@lwn.net>
*/ */
#ifdef CONFIG_KALLSYMS #if defined(CONFIG_KALLSYMS) && defined(CONFIG_SYSFS)
static ssize_t module_sect_show(struct module_attribute *mattr, static ssize_t module_sect_show(struct module_attribute *mattr,
struct module *mod, char *buf) struct module *mod, char *buf)
{ {
...@@ -1188,7 +1187,7 @@ static inline void add_notes_attrs(struct module *mod, unsigned int nsect, ...@@ -1188,7 +1187,7 @@ static inline void add_notes_attrs(struct module *mod, unsigned int nsect,
static inline void remove_notes_attrs(struct module *mod) static inline void remove_notes_attrs(struct module *mod)
{ {
} }
#endif /* CONFIG_KALLSYMS */ #endif
#ifdef CONFIG_SYSFS #ifdef CONFIG_SYSFS
int module_add_modinfo_attrs(struct module *mod) int module_add_modinfo_attrs(struct module *mod)
...@@ -1231,9 +1230,7 @@ void module_remove_modinfo_attrs(struct module *mod) ...@@ -1231,9 +1230,7 @@ void module_remove_modinfo_attrs(struct module *mod)
} }
kfree(mod->modinfo_attrs); kfree(mod->modinfo_attrs);
} }
#endif
#ifdef CONFIG_SYSFS
int mod_sysfs_init(struct module *mod) int mod_sysfs_init(struct module *mod)
{ {
int err; int err;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment