Commit e64f57e8 authored by Tomas Marek's avatar Tomas Marek Committed by Herbert Xu

hwrng: stm32 - fix read of the last word

The stm32_rng_read() function samples TRNG by 4 bytes until at
least 5 bytes are free in the input buffer. The last four bytes
are never read. For example, 60 bytes are returned in case the
input buffer size is 64 bytes.

Read until at least 4 bytes are free in the input buffer. Fill
the buffer entirely in case the buffer size is divisible by 4.

Cc: Oleg Karfich <oleg.karfich@wago.com>
Signed-off-by: default avatarTomas Marek <tomas.marek@elrest.cz>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 7e11a4fc
...@@ -44,7 +44,7 @@ static int stm32_rng_read(struct hwrng *rng, void *data, size_t max, bool wait) ...@@ -44,7 +44,7 @@ static int stm32_rng_read(struct hwrng *rng, void *data, size_t max, bool wait)
pm_runtime_get_sync((struct device *) priv->rng.priv); pm_runtime_get_sync((struct device *) priv->rng.priv);
while (max > sizeof(u32)) { while (max >= sizeof(u32)) {
sr = readl_relaxed(priv->base + RNG_SR); sr = readl_relaxed(priv->base + RNG_SR);
/* Manage timeout which is based on timer and take */ /* Manage timeout which is based on timer and take */
/* care of initial delay time when enabling rng */ /* care of initial delay time when enabling rng */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment