Commit e651f2fa authored by Martin Blumenstingl's avatar Martin Blumenstingl Committed by Daniel Lezcano

clocksource/drivers/arm_global_timer: Guard against division by zero

The result of the division of new_rate by gt_target_rate can be zero (if
new_rate is smaller than gt_target_rate). Using that result as divisor
without checking can result in a division by zero error. Guard against
this by checking for a zero value earlier.
While here, also change the psv variable to an unsigned long to make
sure we don't overflow the datatype as all other types involved are also
unsiged long.
Signed-off-by: default avatarMartin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20240225151336.2728533-3-martin.blumenstingl@googlemail.com
parent f31c2048
...@@ -291,18 +291,17 @@ static int gt_clk_rate_change_cb(struct notifier_block *nb, ...@@ -291,18 +291,17 @@ static int gt_clk_rate_change_cb(struct notifier_block *nb,
switch (event) { switch (event) {
case PRE_RATE_CHANGE: case PRE_RATE_CHANGE:
{ {
int psv; unsigned long psv;
psv = DIV_ROUND_CLOSEST(ndata->new_rate, psv = DIV_ROUND_CLOSEST(ndata->new_rate, gt_target_rate);
gt_target_rate); if (!psv ||
abs(gt_target_rate - (ndata->new_rate / psv)) > MAX_F_ERR)
if (abs(gt_target_rate - (ndata->new_rate / psv)) > MAX_F_ERR)
return NOTIFY_BAD; return NOTIFY_BAD;
psv--; psv--;
/* prescaler within legal range? */ /* prescaler within legal range? */
if (psv < 0 || psv > GT_CONTROL_PRESCALER_MAX) if (psv > GT_CONTROL_PRESCALER_MAX)
return NOTIFY_BAD; return NOTIFY_BAD;
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment