Commit e6a7379f authored by Timur Kristóf's avatar Timur Kristóf Committed by Andy Shevchenko

platform/x86: dell-laptop: Fix keyboard backlight timeout on XPS 13 9370

The XPS 13 9370 doesn't expose the necessary KBD_LED_AC_TOKEN in
the BIOS, so the driver thinks it cannot adjust the AC keyboard
backlight timeout. This patch adds a quirk to fix this until
Dell adds the missing token to the BIOS.

For further discussion, see:
https://github.com/dell/libsmbios/issues/48Signed-off-by: default avatarTimur Kristóf <venemo@fedoraproject.org>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent 64b82464
...@@ -38,6 +38,7 @@ ...@@ -38,6 +38,7 @@
struct quirk_entry { struct quirk_entry {
bool touchpad_led; bool touchpad_led;
bool kbd_led_levels_off_1; bool kbd_led_levels_off_1;
bool kbd_missing_ac_tag;
bool needs_kbd_timeouts; bool needs_kbd_timeouts;
/* /*
...@@ -68,6 +69,10 @@ static struct quirk_entry quirk_dell_xps13_9333 = { ...@@ -68,6 +69,10 @@ static struct quirk_entry quirk_dell_xps13_9333 = {
.kbd_timeouts = { 0, 5, 15, 60, 5 * 60, 15 * 60, -1 }, .kbd_timeouts = { 0, 5, 15, 60, 5 * 60, 15 * 60, -1 },
}; };
static struct quirk_entry quirk_dell_xps13_9370 = {
.kbd_missing_ac_tag = true,
};
static struct quirk_entry quirk_dell_latitude_e6410 = { static struct quirk_entry quirk_dell_latitude_e6410 = {
.kbd_led_levels_off_1 = true, .kbd_led_levels_off_1 = true,
}; };
...@@ -291,6 +296,15 @@ static const struct dmi_system_id dell_quirks[] __initconst = { ...@@ -291,6 +296,15 @@ static const struct dmi_system_id dell_quirks[] __initconst = {
}, },
.driver_data = &quirk_dell_xps13_9333, .driver_data = &quirk_dell_xps13_9333,
}, },
{
.callback = dmi_matched,
.ident = "Dell XPS 13 9370",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
DMI_MATCH(DMI_PRODUCT_NAME, "XPS 13 9370"),
},
.driver_data = &quirk_dell_xps13_9370,
},
{ {
.callback = dmi_matched, .callback = dmi_matched,
.ident = "Dell Latitude E6410", .ident = "Dell Latitude E6410",
...@@ -1401,7 +1415,8 @@ static inline int kbd_init_info(void) ...@@ -1401,7 +1415,8 @@ static inline int kbd_init_info(void)
* timeout value which is shared for both battery and AC power * timeout value which is shared for both battery and AC power
* settings. So do not try to set AC values on old models. * settings. So do not try to set AC values on old models.
*/ */
if (dell_smbios_find_token(KBD_LED_AC_TOKEN)) if ((quirks && quirks->kbd_missing_ac_tag) ||
dell_smbios_find_token(KBD_LED_AC_TOKEN))
kbd_timeout_ac_supported = true; kbd_timeout_ac_supported = true;
kbd_get_state(&state); kbd_get_state(&state);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment