Commit e79b548b authored by Lv Ruyi's avatar Lv Ruyi Committed by Iwona Winiarska

peci: aspeed: fix error check return value of platform_get_irq()

platform_get_irq() return negative value on failure, so null check of
priv->irq is incorrect. Fix it by comparing whether it is less than zero.

Fixes: a85e4c52 ("peci: Add peci-aspeed controller driver")
Reported-by: default avatarZeal Robot <zealci@zte.com.cn>
Signed-off-by: default avatarLv Ruyi <lv.ruyi@zte.com.cn>
Link: https://lore.kernel.org/r/20220413010425.2534887-1-lv.ruyi@zte.com.cnReviewed-by: default avatarIwona Winiarska <iwona.winiarska@intel.com>
Signed-off-by: default avatarIwona Winiarska <iwona.winiarska@intel.com>
parent 568035b0
......@@ -523,7 +523,7 @@ static int aspeed_peci_probe(struct platform_device *pdev)
return PTR_ERR(priv->base);
priv->irq = platform_get_irq(pdev, 0);
if (!priv->irq)
if (priv->irq < 0)
return priv->irq;
ret = devm_request_irq(&pdev->dev, priv->irq, aspeed_peci_irq_handler,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment