Commit e79dd09b authored by Andrzej Hajda's avatar Andrzej Hajda Committed by David S. Miller

orinoco: fix checking for default value

Thresholds uses -1 to indicate that default value should be used.
Since thresholds are unsigned sign checking makes no sense.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576Signed-off-by: default avatarAndrzej Hajda <a.hajda@samsung.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent cc751498
...@@ -220,7 +220,7 @@ static int orinoco_set_wiphy_params(struct wiphy *wiphy, u32 changed) ...@@ -220,7 +220,7 @@ static int orinoco_set_wiphy_params(struct wiphy *wiphy, u32 changed)
if (changed & WIPHY_PARAM_FRAG_THRESHOLD) { if (changed & WIPHY_PARAM_FRAG_THRESHOLD) {
/* Set fragmentation */ /* Set fragmentation */
if (priv->has_mwo) { if (priv->has_mwo) {
if (wiphy->frag_threshold < 0) if (wiphy->frag_threshold == -1)
frag_value = 0; frag_value = 0;
else { else {
printk(KERN_WARNING "%s: Fixed fragmentation " printk(KERN_WARNING "%s: Fixed fragmentation "
...@@ -230,7 +230,7 @@ static int orinoco_set_wiphy_params(struct wiphy *wiphy, u32 changed) ...@@ -230,7 +230,7 @@ static int orinoco_set_wiphy_params(struct wiphy *wiphy, u32 changed)
frag_value = 1; frag_value = 1;
} }
} else { } else {
if (wiphy->frag_threshold < 0) if (wiphy->frag_threshold == -1)
frag_value = 2346; frag_value = 2346;
else if ((wiphy->frag_threshold < 257) || else if ((wiphy->frag_threshold < 257) ||
(wiphy->frag_threshold > 2347)) (wiphy->frag_threshold > 2347))
...@@ -252,7 +252,7 @@ static int orinoco_set_wiphy_params(struct wiphy *wiphy, u32 changed) ...@@ -252,7 +252,7 @@ static int orinoco_set_wiphy_params(struct wiphy *wiphy, u32 changed)
* the upper limit. * the upper limit.
*/ */
if (wiphy->rts_threshold < 0) if (wiphy->rts_threshold == -1)
rts_value = 2347; rts_value = 2347;
else if (wiphy->rts_threshold > 2347) else if (wiphy->rts_threshold > 2347)
err = -EINVAL; err = -EINVAL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment