Commit e7d966f9 authored by Sergey Shtylyov's avatar Sergey Shtylyov Committed by David S. Miller

sh_eth: sh_eth_close() always returns 0

sh_eth_close() always returns 0, hence the check in sh_eth_wol_restore()
is pointless (however we cannot change the prototype of sh_eth_close() as
it implements the driver's ndo_stop() method).

Found by Linux Verification Center (linuxtesting.org) with the SVACE static
analysis tool.
Signed-off-by: default avatarSergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent be94a51f
...@@ -3444,9 +3444,7 @@ static int sh_eth_wol_restore(struct net_device *ndev) ...@@ -3444,9 +3444,7 @@ static int sh_eth_wol_restore(struct net_device *ndev)
* both be reset and all registers restored. This is what * both be reset and all registers restored. This is what
* happens during suspend and resume without WoL enabled. * happens during suspend and resume without WoL enabled.
*/ */
ret = sh_eth_close(ndev); sh_eth_close(ndev);
if (ret < 0)
return ret;
ret = sh_eth_open(ndev); ret = sh_eth_open(ndev);
if (ret < 0) if (ret < 0)
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment