Commit e85f8a9f authored by Peng Wu's avatar Peng Wu Committed by David S. Miller

net: hns: Add missing fwnode_handle_put in hns_mac_init

In one of the error paths of the device_for_each_child_node() loop
in hns_mac_init, add missing call to fwnode_handle_put.
Signed-off-by: default avatarPeng Wu <wupeng58@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c4c89a6a
...@@ -1065,19 +1065,23 @@ int hns_mac_init(struct dsaf_device *dsaf_dev) ...@@ -1065,19 +1065,23 @@ int hns_mac_init(struct dsaf_device *dsaf_dev)
device_for_each_child_node(dsaf_dev->dev, child) { device_for_each_child_node(dsaf_dev->dev, child) {
ret = fwnode_property_read_u32(child, "reg", &port_id); ret = fwnode_property_read_u32(child, "reg", &port_id);
if (ret) { if (ret) {
fwnode_handle_put(child);
dev_err(dsaf_dev->dev, dev_err(dsaf_dev->dev,
"get reg fail, ret=%d!\n", ret); "get reg fail, ret=%d!\n", ret);
return ret; return ret;
} }
if (port_id >= max_port_num) { if (port_id >= max_port_num) {
fwnode_handle_put(child);
dev_err(dsaf_dev->dev, dev_err(dsaf_dev->dev,
"reg(%u) out of range!\n", port_id); "reg(%u) out of range!\n", port_id);
return -EINVAL; return -EINVAL;
} }
mac_cb = devm_kzalloc(dsaf_dev->dev, sizeof(*mac_cb), mac_cb = devm_kzalloc(dsaf_dev->dev, sizeof(*mac_cb),
GFP_KERNEL); GFP_KERNEL);
if (!mac_cb) if (!mac_cb) {
fwnode_handle_put(child);
return -ENOMEM; return -ENOMEM;
}
mac_cb->fw_port = child; mac_cb->fw_port = child;
mac_cb->mac_id = (u8)port_id; mac_cb->mac_id = (u8)port_id;
dsaf_dev->mac_cb[port_id] = mac_cb; dsaf_dev->mac_cb[port_id] = mac_cb;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment