Commit e8df2263 authored by Douglas Anderson's avatar Douglas Anderson Committed by Bjorn Andersson

arm64: dts: qcom: sc7180: Remove superfluous "input-enable"s from trogdor

As talked about in the patch ("dt-bindings: pinctrl: qcom: tlmm should
use output-disable, not input-enable"), using "input-enable" in
pinctrl states for Qualcomm TLMM pinctrl devices was either
superfluous or there to disable a pin's output.

Looking at trogdor:
* ap_ec_int_l, fp_to_ap_irq_l, h1_ap_int_odl, p_sensor_int_l:
  Superfluous. The pins will be configured as inputs automatically by
  the Linux GPIO subsystem (presumably the reference for other OSes
  using these device trees).
* bios_flash_wp_l: Superfluous. This pin is exposed to userspace
  through the kernel's GPIO API and will be configured automatically.

That means that in none of the cases for trogdor did we need to change
"input-enable" to "output-disable" and we can just remove these
superfluous properties.
Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20230323102605.9.I94dbc53176e8adb0d7673b7feb2368e85418f938@changeid
parent ced32c29
...@@ -1206,7 +1206,6 @@ amp_en: amp-en-state { ...@@ -1206,7 +1206,6 @@ amp_en: amp-en-state {
ap_ec_int_l: ap-ec-int-l-state { ap_ec_int_l: ap-ec-int-l-state {
pins = "gpio94"; pins = "gpio94";
function = "gpio"; function = "gpio";
input-enable;
bias-pull-up; bias-pull-up;
}; };
...@@ -1229,7 +1228,6 @@ ap_suspend_l_neuter: ap-suspend-l-neuter-state { ...@@ -1229,7 +1228,6 @@ ap_suspend_l_neuter: ap-suspend-l-neuter-state {
bios_flash_wp_l: bios-flash-wp-l-state { bios_flash_wp_l: bios-flash-wp-l-state {
pins = "gpio66"; pins = "gpio66";
function = "gpio"; function = "gpio";
input-enable;
bias-disable; bias-disable;
}; };
...@@ -1271,7 +1269,6 @@ fp_rst_l: fp-rst-l-state { ...@@ -1271,7 +1269,6 @@ fp_rst_l: fp-rst-l-state {
fp_to_ap_irq_l: fp-to-ap-irq-l-state { fp_to_ap_irq_l: fp-to-ap-irq-l-state {
pins = "gpio4"; pins = "gpio4";
function = "gpio"; function = "gpio";
input-enable;
/* Has external pullup */ /* Has external pullup */
bias-disable; bias-disable;
...@@ -1286,7 +1283,6 @@ fpmcu_boot0: fpmcu-boot0-state { ...@@ -1286,7 +1283,6 @@ fpmcu_boot0: fpmcu-boot0-state {
h1_ap_int_odl: h1-ap-int-odl-state { h1_ap_int_odl: h1-ap-int-odl-state {
pins = "gpio42"; pins = "gpio42";
function = "gpio"; function = "gpio";
input-enable;
bias-pull-up; bias-pull-up;
}; };
...@@ -1335,7 +1331,6 @@ pen_rst_odl: pen-rst-odl-state { ...@@ -1335,7 +1331,6 @@ pen_rst_odl: pen-rst-odl-state {
p_sensor_int_l: p-sensor-int-l-state { p_sensor_int_l: p-sensor-int-l-state {
pins = "gpio24"; pins = "gpio24";
function = "gpio"; function = "gpio";
input-enable;
/* Has external pullup */ /* Has external pullup */
bias-disable; bias-disable;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment