Commit e9229d5b authored by Shang XiaoJing's avatar Shang XiaoJing Committed by Arnaldo Carvalho de Melo

perf vendor events arm64: Fix incorrect Hisi hip08 L3 metrics

Commit 0cc177cf ("perf vendor events arm64: Add Hisi hip08 L3
metrics") add L3 metrics of hip08, but some metrics (IF_BP_MISP_BR_RET,
IF_BP_MISP_BR_RET, IF_BP_MISP_BR_BL) have incorrect event number due to
the mistakes in document, which caused incorrect result. Fix the
incorrect metrics.

Before:

  65,811,214,308	armv8_pmuv3_0/event=0x1014/	# 18.87 push_branch
  							# -40.19 other_branch
  3,564,316,780	BR_MIS_PRED				# 0.51 indirect_branch
  							# 21.81 pop_branch

After:

  6,537,146,245	BR_MIS_PRED			# 0.48 indirect_branch
  						# 0.47 pop_branch
  						# 0.00 push_branch
  						# 0.05 other_branch

Fixes: 0cc177cf ("perf vendor events arm64: Add Hisi hip08 L3 metrics")
Reviewed-by: default avatarJohn Garry <john.garry@huawei.com>
Signed-off-by: default avatarShang XiaoJing <shangxiaojing@huawei.com>
Acked-by: default avatarJames Clark <james.clark@arm.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: John Garry <john.garry@huawei.com>
Cc: Kajol Jain <kjain@linux.ibm.com>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Mike Leach <mike.leach@linaro.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Will Deacon <will@kernel.org>
Link: https://lore.kernel.org/r/20221021105035.10000-2-shangxiaojing@huawei.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent cba04f31
...@@ -112,21 +112,21 @@ ...@@ -112,21 +112,21 @@
"MetricName": "indirect_branch" "MetricName": "indirect_branch"
}, },
{ {
"MetricExpr": "(armv8_pmuv3_0@event\\=0x1014@ + armv8_pmuv3_0@event\\=0x1018@) / BR_MIS_PRED", "MetricExpr": "(armv8_pmuv3_0@event\\=0x1013@ + armv8_pmuv3_0@event\\=0x1016@) / BR_MIS_PRED",
"PublicDescription": "Push branch L3 topdown metric", "PublicDescription": "Push branch L3 topdown metric",
"BriefDescription": "Push branch L3 topdown metric", "BriefDescription": "Push branch L3 topdown metric",
"MetricGroup": "TopDownL3", "MetricGroup": "TopDownL3",
"MetricName": "push_branch" "MetricName": "push_branch"
}, },
{ {
"MetricExpr": "armv8_pmuv3_0@event\\=0x100c@ / BR_MIS_PRED", "MetricExpr": "armv8_pmuv3_0@event\\=0x100d@ / BR_MIS_PRED",
"PublicDescription": "Pop branch L3 topdown metric", "PublicDescription": "Pop branch L3 topdown metric",
"BriefDescription": "Pop branch L3 topdown metric", "BriefDescription": "Pop branch L3 topdown metric",
"MetricGroup": "TopDownL3", "MetricGroup": "TopDownL3",
"MetricName": "pop_branch" "MetricName": "pop_branch"
}, },
{ {
"MetricExpr": "(BR_MIS_PRED - armv8_pmuv3_0@event\\=0x1010@ - armv8_pmuv3_0@event\\=0x1014@ - armv8_pmuv3_0@event\\=0x1018@ - armv8_pmuv3_0@event\\=0x100c@) / BR_MIS_PRED", "MetricExpr": "(BR_MIS_PRED - armv8_pmuv3_0@event\\=0x1010@ - armv8_pmuv3_0@event\\=0x1013@ - armv8_pmuv3_0@event\\=0x1016@ - armv8_pmuv3_0@event\\=0x100d@) / BR_MIS_PRED",
"PublicDescription": "Other branch L3 topdown metric", "PublicDescription": "Other branch L3 topdown metric",
"BriefDescription": "Other branch L3 topdown metric", "BriefDescription": "Other branch L3 topdown metric",
"MetricGroup": "TopDownL3", "MetricGroup": "TopDownL3",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment