Commit e9c0c874 authored by Mathieu Malaterre's avatar Mathieu Malaterre Committed by Daniel Vetter

drm/dp: annotate implicit fall throughs

There is a plan to build the kernel with -Wimplicit-fallthrough and
these places in the code produced warnings (W=1). Fix them up.

This commit remove the following warnings:

  include/linux/compiler.h:77:22: warning: this statement may fall through [-Wimplicit-fallthrough=]
  include/asm-generic/bug.h:134:2: note: in expansion of macro 'unlikely'
  drivers/gpu/drm/drm_dp_helper.c:155:3: note: in expansion of macro 'WARN'
  include/linux/compiler.h:77:22: warning: this statement may fall through [-Wimplicit-fallthrough=]
  include/asm-generic/bug.h:134:2: note: in expansion of macro 'unlikely'
  drivers/gpu/drm/drm_dp_helper.c:173:3: note: in expansion of macro 'WARN'
  drivers/gpu/drm/drm_dp_helper.c:547:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
Signed-off-by: default avatarMathieu Malaterre <malat@debian.org>
Acked-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20190114202748.15584-1-malat@debian.org
parent 2db8ebca
...@@ -154,6 +154,7 @@ u8 drm_dp_link_rate_to_bw_code(int link_rate) ...@@ -154,6 +154,7 @@ u8 drm_dp_link_rate_to_bw_code(int link_rate)
default: default:
WARN(1, "unknown DP link rate %d, using %x\n", link_rate, WARN(1, "unknown DP link rate %d, using %x\n", link_rate,
DP_LINK_BW_1_62); DP_LINK_BW_1_62);
/* fall through */
case 162000: case 162000:
return DP_LINK_BW_1_62; return DP_LINK_BW_1_62;
case 270000: case 270000:
...@@ -171,6 +172,7 @@ int drm_dp_bw_code_to_link_rate(u8 link_bw) ...@@ -171,6 +172,7 @@ int drm_dp_bw_code_to_link_rate(u8 link_bw)
switch (link_bw) { switch (link_bw) {
default: default:
WARN(1, "unknown DP link BW code %x, using 162000\n", link_bw); WARN(1, "unknown DP link BW code %x, using 162000\n", link_bw);
/* fall through */
case DP_LINK_BW_1_62: case DP_LINK_BW_1_62:
return 162000; return 162000;
case DP_LINK_BW_2_7: case DP_LINK_BW_2_7:
...@@ -552,6 +554,7 @@ int drm_dp_downstream_max_bpc(const u8 dpcd[DP_RECEIVER_CAP_SIZE], ...@@ -552,6 +554,7 @@ int drm_dp_downstream_max_bpc(const u8 dpcd[DP_RECEIVER_CAP_SIZE],
case DP_DS_16BPC: case DP_DS_16BPC:
return 16; return 16;
} }
/* fall through */
default: default:
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment