Commit eafd4e60 authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman

ACPI, PCI, irq: remove redundant check for null string pointer

commit 45288978 upstream.

source is decleared as a 4 byte char array in struct acpi_pci_routing_table
so !prt->source is a redundant null string pointer check. Detected with
smatch:

drivers/acpi/pci_irq.c:134 do_prt_fixups() warn: this array is probably
  non-NULL. 'prt->source'
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Cc: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent dd26ec7f
...@@ -131,9 +131,6 @@ static void do_prt_fixups(struct acpi_prt_entry *entry, ...@@ -131,9 +131,6 @@ static void do_prt_fixups(struct acpi_prt_entry *entry,
quirk = &prt_quirks[i]; quirk = &prt_quirks[i];
/* All current quirks involve link devices, not GSIs */ /* All current quirks involve link devices, not GSIs */
if (!prt->source)
continue;
if (dmi_check_system(quirk->system) && if (dmi_check_system(quirk->system) &&
entry->id.segment == quirk->segment && entry->id.segment == quirk->segment &&
entry->id.bus == quirk->bus && entry->id.bus == quirk->bus &&
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment