Commit eb12db69 authored by Josef Bacik's avatar Josef Bacik

Btrfs: fix freeing delayed ref head while still holding its mutex

I hit this error when reproducing a bug that would end in a transaction
abort.  We take the delayed ref head's mutex to keep anybody from processing
it while we're destroying it, but we fail to drop the mutex before we carry
on and free the damned thing.  Fix this by doing the remove logic for the
head ourselves and unlock the mutex, that way we can avoid use after free's
or hung tasks waiting on that mutex to come back so they know the delayed
ref completed.  Thanks,
Signed-off-by: default avatarJosef Bacik <jbacik@fusionio.com>
parent 063d006f
...@@ -3615,11 +3615,11 @@ int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans, ...@@ -3615,11 +3615,11 @@ int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans,
} }
while ((node = rb_first(&delayed_refs->root)) != NULL) { while ((node = rb_first(&delayed_refs->root)) != NULL) {
ref = rb_entry(node, struct btrfs_delayed_ref_node, rb_node); struct btrfs_delayed_ref_head *head = NULL;
ref = rb_entry(node, struct btrfs_delayed_ref_node, rb_node);
atomic_set(&ref->refs, 1); atomic_set(&ref->refs, 1);
if (btrfs_delayed_ref_is_head(ref)) { if (btrfs_delayed_ref_is_head(ref)) {
struct btrfs_delayed_ref_head *head;
head = btrfs_delayed_node_to_head(ref); head = btrfs_delayed_node_to_head(ref);
if (!mutex_trylock(&head->mutex)) { if (!mutex_trylock(&head->mutex)) {
...@@ -3641,10 +3641,12 @@ int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans, ...@@ -3641,10 +3641,12 @@ int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans,
delayed_refs->num_heads_ready--; delayed_refs->num_heads_ready--;
list_del_init(&head->cluster); list_del_init(&head->cluster);
} }
ref->in_tree = 0; ref->in_tree = 0;
rb_erase(&ref->rb_node, &delayed_refs->root); rb_erase(&ref->rb_node, &delayed_refs->root);
delayed_refs->num_entries--; delayed_refs->num_entries--;
if (head)
mutex_unlock(&head->mutex);
spin_unlock(&delayed_refs->lock); spin_unlock(&delayed_refs->lock);
btrfs_put_delayed_ref(ref); btrfs_put_delayed_ref(ref);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment