Commit eb479f86 authored by Chris Wilson's avatar Chris Wilson

drm/i915: Limit searching for PIN_HIGH

To no surprise (since we've flip-flopped over the use of PIN_HIGH a few
times), doing a search by address over a pathologically fragmented
address space is exceeding slow. To protect ourselves from nearly
unbounded latency (think searching a million holes while under
struct_mutex), limit the search for the highest available hole and
fallback to best-fit if it fails.

In the pathologically fragmented case, such as igt/gem_ctx_thrash, the
effect is dramatic, bringing the runtime down from hours to seconds
(depending on how many other slow searches you hit, e.g. alloc_iova()
and alloc_vmap_area() both degrade to a slow rbtree walk after their
small cache is exhausted). For the real world, the number of search
steps is unlikely to be significant as we should only need to search
once per new context.
Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: default avatarJoonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180521082131.13744-3-chris@chris-wilson.co.uk
parent 83bc4ec3
...@@ -3972,7 +3972,7 @@ int i915_gem_gtt_insert(struct i915_address_space *vm, ...@@ -3972,7 +3972,7 @@ int i915_gem_gtt_insert(struct i915_address_space *vm,
mode = DRM_MM_INSERT_BEST; mode = DRM_MM_INSERT_BEST;
if (flags & PIN_HIGH) if (flags & PIN_HIGH)
mode = DRM_MM_INSERT_HIGH; mode = DRM_MM_INSERT_HIGHEST;
if (flags & PIN_MAPPABLE) if (flags & PIN_MAPPABLE)
mode = DRM_MM_INSERT_LOW; mode = DRM_MM_INSERT_LOW;
...@@ -3992,6 +3992,15 @@ int i915_gem_gtt_insert(struct i915_address_space *vm, ...@@ -3992,6 +3992,15 @@ int i915_gem_gtt_insert(struct i915_address_space *vm,
if (err != -ENOSPC) if (err != -ENOSPC)
return err; return err;
if (mode & DRM_MM_INSERT_ONCE) {
err = drm_mm_insert_node_in_range(&vm->mm, node,
size, alignment, color,
start, end,
DRM_MM_INSERT_BEST);
if (err != -ENOSPC)
return err;
}
if (flags & PIN_NOEVICT) if (flags & PIN_NOEVICT)
return -ENOSPC; return -ENOSPC;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment