Commit ec18d7e7 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Bartosz Golaszewski

gpio: uniphier: Replace zero-length array with flexible-array member

The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertenly introduced[3] to the codebase from now on.

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732 ("cxgb3/l2t: Fix undefined behaviour")
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
parent 869233f8
...@@ -30,7 +30,7 @@ struct uniphier_gpio_priv { ...@@ -30,7 +30,7 @@ struct uniphier_gpio_priv {
struct irq_domain *domain; struct irq_domain *domain;
void __iomem *regs; void __iomem *regs;
spinlock_t lock; spinlock_t lock;
u32 saved_vals[0]; u32 saved_vals[];
}; };
static unsigned int uniphier_gpio_bank_to_reg(unsigned int bank) static unsigned int uniphier_gpio_bank_to_reg(unsigned int bank)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment