Commit ecbf4724 authored by Muchun Song's avatar Muchun Song Committed by Linus Torvalds

mm: hugetlb: remove VM_BUG_ON_PAGE from page_huge_active

The page_huge_active() can be called from scan_movable_pages() which do
not hold a reference count to the HugeTLB page.  So when we call
page_huge_active() from scan_movable_pages(), the HugeTLB page can be
freed parallel.  Then we will trigger a BUG_ON which is in the
page_huge_active() when CONFIG_DEBUG_VM is enabled.  Just remove the
VM_BUG_ON_PAGE.

Link: https://lkml.kernel.org/r/20210115124942.46403-6-songmuchun@bytedance.com
Fixes: 7e1f049e ("mm: hugetlb: cleanup using paeg_huge_active()")
Signed-off-by: default avatarMuchun Song <songmuchun@bytedance.com>
Reviewed-by: default avatarMike Kravetz <mike.kravetz@oracle.com>
Acked-by: default avatarMichal Hocko <mhocko@suse.com>
Reviewed-by: default avatarOscar Salvador <osalvador@suse.de>
Cc: David Hildenbrand <david@redhat.com>
Cc: Yang Shi <shy828301@gmail.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 0eb2df2b
...@@ -1361,8 +1361,7 @@ struct hstate *size_to_hstate(unsigned long size) ...@@ -1361,8 +1361,7 @@ struct hstate *size_to_hstate(unsigned long size)
*/ */
bool page_huge_active(struct page *page) bool page_huge_active(struct page *page)
{ {
VM_BUG_ON_PAGE(!PageHuge(page), page); return PageHeadHuge(page) && PagePrivate(&page[1]);
return PageHead(page) && PagePrivate(&page[1]);
} }
/* never called for tail page */ /* never called for tail page */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment