Commit ecf49cad authored by Phil Sutter's avatar Phil Sutter Committed by Pablo Neira Ayuso

netfilter: nf_tables: A better name for nft_obj_filter

Name it for what it is supposed to become, a real nft_obj_dump_ctx. No
functional change intended.
Signed-off-by: default avatarPhil Sutter <phil@nwl.cc>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent 4279cc60
...@@ -7681,7 +7681,7 @@ static void audit_log_obj_reset(const struct nft_table *table, ...@@ -7681,7 +7681,7 @@ static void audit_log_obj_reset(const struct nft_table *table,
kfree(buf); kfree(buf);
} }
struct nft_obj_filter { struct nft_obj_dump_ctx {
char *table; char *table;
u32 type; u32 type;
}; };
...@@ -7691,7 +7691,7 @@ static int nf_tables_dump_obj(struct sk_buff *skb, struct netlink_callback *cb) ...@@ -7691,7 +7691,7 @@ static int nf_tables_dump_obj(struct sk_buff *skb, struct netlink_callback *cb)
const struct nfgenmsg *nfmsg = nlmsg_data(cb->nlh); const struct nfgenmsg *nfmsg = nlmsg_data(cb->nlh);
const struct nft_table *table; const struct nft_table *table;
unsigned int idx = 0, s_idx = cb->args[0]; unsigned int idx = 0, s_idx = cb->args[0];
struct nft_obj_filter *filter = cb->data; struct nft_obj_dump_ctx *ctx = cb->data;
struct net *net = sock_net(skb->sk); struct net *net = sock_net(skb->sk);
int family = nfmsg->nfgen_family; int family = nfmsg->nfgen_family;
struct nftables_pernet *nft_net; struct nftables_pernet *nft_net;
...@@ -7717,10 +7717,10 @@ static int nf_tables_dump_obj(struct sk_buff *skb, struct netlink_callback *cb) ...@@ -7717,10 +7717,10 @@ static int nf_tables_dump_obj(struct sk_buff *skb, struct netlink_callback *cb)
goto cont; goto cont;
if (idx < s_idx) if (idx < s_idx)
goto cont; goto cont;
if (filter->table && strcmp(filter->table, table->name)) if (ctx->table && strcmp(ctx->table, table->name))
goto cont; goto cont;
if (filter->type != NFT_OBJECT_UNSPEC && if (ctx->type != NFT_OBJECT_UNSPEC &&
obj->ops->type->type != filter->type) obj->ops->type->type != ctx->type)
goto cont; goto cont;
rc = nf_tables_fill_obj_info(skb, net, rc = nf_tables_fill_obj_info(skb, net,
...@@ -7752,33 +7752,33 @@ static int nf_tables_dump_obj(struct sk_buff *skb, struct netlink_callback *cb) ...@@ -7752,33 +7752,33 @@ static int nf_tables_dump_obj(struct sk_buff *skb, struct netlink_callback *cb)
static int nf_tables_dump_obj_start(struct netlink_callback *cb) static int nf_tables_dump_obj_start(struct netlink_callback *cb)
{ {
const struct nlattr * const *nla = cb->data; const struct nlattr * const *nla = cb->data;
struct nft_obj_filter *filter = NULL; struct nft_obj_dump_ctx *ctx = NULL;
filter = kzalloc(sizeof(*filter), GFP_ATOMIC); ctx = kzalloc(sizeof(*ctx), GFP_ATOMIC);
if (!filter) if (!ctx)
return -ENOMEM; return -ENOMEM;
if (nla[NFTA_OBJ_TABLE]) { if (nla[NFTA_OBJ_TABLE]) {
filter->table = nla_strdup(nla[NFTA_OBJ_TABLE], GFP_ATOMIC); ctx->table = nla_strdup(nla[NFTA_OBJ_TABLE], GFP_ATOMIC);
if (!filter->table) { if (!ctx->table) {
kfree(filter); kfree(ctx);
return -ENOMEM; return -ENOMEM;
} }
} }
if (nla[NFTA_OBJ_TYPE]) if (nla[NFTA_OBJ_TYPE])
filter->type = ntohl(nla_get_be32(nla[NFTA_OBJ_TYPE])); ctx->type = ntohl(nla_get_be32(nla[NFTA_OBJ_TYPE]));
cb->data = filter; cb->data = ctx;
return 0; return 0;
} }
static int nf_tables_dump_obj_done(struct netlink_callback *cb) static int nf_tables_dump_obj_done(struct netlink_callback *cb)
{ {
struct nft_obj_filter *filter = cb->data; struct nft_obj_dump_ctx *ctx = cb->data;
kfree(filter->table); kfree(ctx->table);
kfree(filter); kfree(ctx);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment