Commit edc4e851 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Maxime Ripard

Revert "drm/display: Make all helpers visible and switch to depends on"

This reverts commit d674858f, as helper
code should always be selected by the driver that needs it, for the
convenience of the final user configuring a kernel.

The user who configures a kernel should not need to know which helpers
are needed for the driver he is interested in.  Making a driver depend
on helper code means that the user needs to know which helpers to enable
first, which is very user-unfriendly.
Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Acked-by: default avatarArnd Bergmann <arnd@arndb.de>
Link: https://patchwork.freedesktop.org/patch/msgid/3db958e3f4002e26cd963596d810c37feb315fb3.1713780345.git.geert+renesas@glider.beSigned-off-by: default avatarMaxime Ripard <mripard@kernel.org>
parent 8f7f1155
# SPDX-License-Identifier: MIT # SPDX-License-Identifier: MIT
config DRM_DISPLAY_HELPER config DRM_DISPLAY_HELPER
tristate "DRM Display Helpers" tristate
depends on DRM depends on DRM
help help
DRM helpers for display adapters. DRM helpers for display adapters.
config DRM_DISPLAY_DP_AUX_BUS config DRM_DISPLAY_DP_AUX_BUS
tristate "DRM DisplayPort AUX bus support" tristate
depends on DRM depends on DRM
depends on OF || COMPILE_TEST depends on OF || COMPILE_TEST
config DRM_DISPLAY_DP_AUX_CEC config DRM_DISPLAY_DP_AUX_CEC
bool "Enable DisplayPort CEC-Tunneling-over-AUX HDMI support" bool "Enable DisplayPort CEC-Tunneling-over-AUX HDMI support"
depends on DRM depends on DRM && DRM_DISPLAY_HELPER
depends on DRM_DISPLAY_HELPER select DRM_DISPLAY_DP_HELPER
depends on DRM_DISPLAY_DP_HELPER
select CEC_CORE select CEC_CORE
help help
Choose this option if you want to enable HDMI CEC support for Choose this option if you want to enable HDMI CEC support for
...@@ -25,24 +24,23 @@ config DRM_DISPLAY_DP_AUX_CEC ...@@ -25,24 +24,23 @@ config DRM_DISPLAY_DP_AUX_CEC
that do support this they often do not hook up the CEC pin. that do support this they often do not hook up the CEC pin.
config DRM_DISPLAY_DP_AUX_CHARDEV config DRM_DISPLAY_DP_AUX_CHARDEV
bool "DRM DisplayPort AUX Interface" bool "DRM DP AUX Interface"
depends on DRM depends on DRM && DRM_DISPLAY_HELPER
depends on DRM_DISPLAY_HELPER select DRM_DISPLAY_DP_HELPER
depends on DRM_DISPLAY_DP_HELPER
help help
Choose this option to enable a /dev/drm_dp_auxN node that allows to Choose this option to enable a /dev/drm_dp_auxN node that allows to
read and write values to arbitrary DPCD registers on the DP aux read and write values to arbitrary DPCD registers on the DP aux
channel. channel.
config DRM_DISPLAY_DP_HELPER config DRM_DISPLAY_DP_HELPER
bool "DRM DisplayPort Helpers" bool
depends on DRM_DISPLAY_HELPER depends on DRM_DISPLAY_HELPER
help help
DRM display helpers for DisplayPort. DRM display helpers for DisplayPort.
config DRM_DISPLAY_DP_TUNNEL config DRM_DISPLAY_DP_TUNNEL
bool "DRM DisplayPort tunnels support" bool
depends on DRM_DISPLAY_DP_HELPER select DRM_DISPLAY_DP_HELPER
help help
Enable support for DisplayPort tunnels. This allows drivers to use Enable support for DisplayPort tunnels. This allows drivers to use
DP tunnel features like the Bandwidth Allocation mode to maximize the DP tunnel features like the Bandwidth Allocation mode to maximize the
...@@ -62,13 +60,13 @@ config DRM_DISPLAY_DP_TUNNEL_STATE_DEBUG ...@@ -62,13 +60,13 @@ config DRM_DISPLAY_DP_TUNNEL_STATE_DEBUG
If in doubt, say "N". If in doubt, say "N".
config DRM_DISPLAY_HDCP_HELPER config DRM_DISPLAY_HDCP_HELPER
bool "DRM HDCD Helpers" bool
depends on DRM_DISPLAY_HELPER depends on DRM_DISPLAY_HELPER
help help
DRM display helpers for HDCP. DRM display helpers for HDCP.
config DRM_DISPLAY_HDMI_HELPER config DRM_DISPLAY_HDMI_HELPER
bool "DRM HDMI Helpers" bool
depends on DRM_DISPLAY_HELPER depends on DRM_DISPLAY_HELPER
help help
DRM display helpers for HDMI. DRM display helpers for HDMI.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment