Commit eddf6711 authored by Dario Binacchi's avatar Dario Binacchi Committed by Marc Kleine-Budde

can: c_can: add a comment about IF_RX interface's use

After reading the commit 640916db ("can: c_can: Make it SMP safe")
it may sound strange to see the IF_RX interface used by the
can_inval_tx_object function. A comment was added to avoid any
misunderstanding.

Link: https://lore.kernel.org/r/20210302215435.18286-4-dariobin@libero.itSigned-off-by: default avatarDario Binacchi <dariobin@libero.it>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent c8a6b443
...@@ -710,6 +710,11 @@ static void c_can_do_tx(struct net_device *dev) ...@@ -710,6 +710,11 @@ static void c_can_do_tx(struct net_device *dev)
idx--; idx--;
pend &= ~(1 << idx); pend &= ~(1 << idx);
obj = idx + C_CAN_MSG_OBJ_TX_FIRST; obj = idx + C_CAN_MSG_OBJ_TX_FIRST;
/* We use IF_RX interface instead of IF_TX because we
* are called from c_can_poll(), which runs inside
* NAPI. We are not trasmitting.
*/
c_can_inval_tx_object(dev, IF_RX, obj); c_can_inval_tx_object(dev, IF_RX, obj);
can_get_echo_skb(dev, idx, NULL); can_get_echo_skb(dev, idx, NULL);
bytes += priv->dlc[idx]; bytes += priv->dlc[idx];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment