Commit ee16d7d3 authored by Stephen Brennan's avatar Stephen Brennan Committed by Greg Kroah-Hartman

staging: rtl8192u: fix OPEN_BRACE errors in ieee80211

Checkpatch emits several errors regarding braces being on the incorrect
line. These can be fixed by moving the brace, do this. In a few cases,
some comments were moved to facilitate this.
Signed-off-by: default avatarStephen Brennan <stephen@brennan.io>
Link: https://lore.kernel.org/r/20190821143540.4501-2-stephen@brennan.ioSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6808f8cf
...@@ -458,8 +458,7 @@ do { if (ieee80211_debug_level & (level)) \ ...@@ -458,8 +458,7 @@ do { if (ieee80211_debug_level & (level)) \
int i; \ int i; \
u8 *pdata = (u8 *) data; \ u8 *pdata = (u8 *) data; \
printk(KERN_DEBUG "ieee80211: %s()\n", __func__); \ printk(KERN_DEBUG "ieee80211: %s()\n", __func__); \
for (i = 0; i < (int)(datalen); i++) \ for (i = 0; i < (int)(datalen); i++) { \
{ \
printk("%2x ", pdata[i]); \ printk("%2x ", pdata[i]); \
if ((i + 1) % 16 == 0) printk("\n"); \ if ((i + 1) % 16 == 0) printk("\n"); \
} \ } \
......
...@@ -214,7 +214,8 @@ int ieee80211_encrypt_fragment( ...@@ -214,7 +214,8 @@ int ieee80211_encrypt_fragment(
} }
void ieee80211_txb_free(struct ieee80211_txb *txb) { void ieee80211_txb_free(struct ieee80211_txb *txb)
{
//int i; //int i;
if (unlikely(!txb)) if (unlikely(!txb))
return; return;
...@@ -333,8 +334,7 @@ static void ieee80211_tx_query_agg_cap(struct ieee80211_device *ieee, ...@@ -333,8 +334,7 @@ static void ieee80211_tx_query_agg_cap(struct ieee80211_device *ieee,
} }
} }
FORCED_AGG_SETTING: FORCED_AGG_SETTING:
switch (pHTInfo->ForcedAMPDUMode ) switch (pHTInfo->ForcedAMPDUMode ) {
{
case HT_AGG_AUTO: case HT_AGG_AUTO:
break; break;
...@@ -424,19 +424,15 @@ static void ieee80211_query_protectionmode(struct ieee80211_device *ieee, ...@@ -424,19 +424,15 @@ static void ieee80211_query_protectionmode(struct ieee80211_device *ieee,
if (is_broadcast_ether_addr(skb->data+16)) //check addr3 as infrastructure add3 is DA. if (is_broadcast_ether_addr(skb->data+16)) //check addr3 as infrastructure add3 is DA.
return; return;
if (ieee->mode < IEEE_N_24G) //b, g mode if (ieee->mode < IEEE_N_24G) /* b, g mode */ {
{
// (1) RTS_Threshold is compared to the MPDU, not MSDU. // (1) RTS_Threshold is compared to the MPDU, not MSDU.
// (2) If there are more than one frag in this MSDU, only the first frag uses protection frame. // (2) If there are more than one frag in this MSDU, only the first frag uses protection frame.
// Other fragments are protected by previous fragment. // Other fragments are protected by previous fragment.
// So we only need to check the length of first fragment. // So we only need to check the length of first fragment.
if (skb->len > ieee->rts) if (skb->len > ieee->rts) {
{
tcb_desc->bRTSEnable = true; tcb_desc->bRTSEnable = true;
tcb_desc->rts_rate = MGN_24M; tcb_desc->rts_rate = MGN_24M;
} } else if (ieee->current_network.buseprotection) {
else if (ieee->current_network.buseprotection)
{
// Use CTS-to-SELF in protection mode. // Use CTS-to-SELF in protection mode.
tcb_desc->bRTSEnable = true; tcb_desc->bRTSEnable = true;
tcb_desc->bCTSEnable = true; tcb_desc->bCTSEnable = true;
...@@ -444,43 +440,35 @@ static void ieee80211_query_protectionmode(struct ieee80211_device *ieee, ...@@ -444,43 +440,35 @@ static void ieee80211_query_protectionmode(struct ieee80211_device *ieee,
} }
//otherwise return; //otherwise return;
return; return;
} } else { // 11n High throughput case.
else
{// 11n High throughput case.
PRT_HIGH_THROUGHPUT pHTInfo = ieee->pHTInfo; PRT_HIGH_THROUGHPUT pHTInfo = ieee->pHTInfo;
while (true) while (true) {
{
//check ERP protection //check ERP protection
if (ieee->current_network.buseprotection) if (ieee->current_network.buseprotection) {// CTS-to-SELF
{// CTS-to-SELF
tcb_desc->bRTSEnable = true; tcb_desc->bRTSEnable = true;
tcb_desc->bCTSEnable = true; tcb_desc->bCTSEnable = true;
tcb_desc->rts_rate = MGN_24M; tcb_desc->rts_rate = MGN_24M;
break; break;
} }
//check HT op mode //check HT op mode
if(pHTInfo->bCurrentHTSupport && pHTInfo->bEnableHT) if(pHTInfo->bCurrentHTSupport && pHTInfo->bEnableHT) {
{
u8 HTOpMode = pHTInfo->CurrentOpMode; u8 HTOpMode = pHTInfo->CurrentOpMode;
if((pHTInfo->bCurBW40MHz && (HTOpMode == 2 || HTOpMode == 3)) || if((pHTInfo->bCurBW40MHz && (HTOpMode == 2 || HTOpMode == 3)) ||
(!pHTInfo->bCurBW40MHz && HTOpMode == 3) ) (!pHTInfo->bCurBW40MHz && HTOpMode == 3)) {
{
tcb_desc->rts_rate = MGN_24M; // Rate is 24Mbps. tcb_desc->rts_rate = MGN_24M; // Rate is 24Mbps.
tcb_desc->bRTSEnable = true; tcb_desc->bRTSEnable = true;
break; break;
} }
} }
//check rts //check rts
if (skb->len > ieee->rts) if (skb->len > ieee->rts) {
{
tcb_desc->rts_rate = MGN_24M; // Rate is 24Mbps. tcb_desc->rts_rate = MGN_24M; // Rate is 24Mbps.
tcb_desc->bRTSEnable = true; tcb_desc->bRTSEnable = true;
break; break;
} }
//to do list: check MIMO power save condition. //to do list: check MIMO power save condition.
//check AMPDU aggregation for TXOP //check AMPDU aggregation for TXOP
if(tcb_desc->bAMPDUEnable) if(tcb_desc->bAMPDUEnable) {
{
tcb_desc->rts_rate = MGN_24M; // Rate is 24Mbps. tcb_desc->rts_rate = MGN_24M; // Rate is 24Mbps.
// According to 8190 design, firmware sends CF-End only if RTS/CTS is enabled. However, it degrads // According to 8190 design, firmware sends CF-End only if RTS/CTS is enabled. However, it degrads
// throughput around 10M, so we disable of this mechanism. 2007.08.03 by Emily // throughput around 10M, so we disable of this mechanism. 2007.08.03 by Emily
...@@ -488,8 +476,7 @@ static void ieee80211_query_protectionmode(struct ieee80211_device *ieee, ...@@ -488,8 +476,7 @@ static void ieee80211_query_protectionmode(struct ieee80211_device *ieee,
break; break;
} }
//check IOT action //check IOT action
if(pHTInfo->IOTAction & HT_IOT_ACT_FORCED_CTS2SELF) if(pHTInfo->IOTAction & HT_IOT_ACT_FORCED_CTS2SELF) {
{
tcb_desc->bCTSEnable = true; tcb_desc->bCTSEnable = true;
tcb_desc->rts_rate = MGN_24M; tcb_desc->rts_rate = MGN_24M;
tcb_desc->bRTSEnable = true; tcb_desc->bRTSEnable = true;
...@@ -541,8 +528,7 @@ static void ieee80211_txrate_selectmode(struct ieee80211_device *ieee, ...@@ -541,8 +528,7 @@ static void ieee80211_txrate_selectmode(struct ieee80211_device *ieee,
if (ieee->bTxUseDriverAssingedRate) if (ieee->bTxUseDriverAssingedRate)
tcb_desc->bTxUseDriverAssingedRate = true; tcb_desc->bTxUseDriverAssingedRate = true;
if (!tcb_desc->bTxDisableRateFallBack || !tcb_desc->bTxUseDriverAssingedRate) if (!tcb_desc->bTxDisableRateFallBack || !tcb_desc->bTxUseDriverAssingedRate) {
{
if (ieee->iw_mode == IW_MODE_INFRA || ieee->iw_mode == IW_MODE_ADHOC) if (ieee->iw_mode == IW_MODE_INFRA || ieee->iw_mode == IW_MODE_ADHOC)
tcb_desc->RATRIndex = 0; tcb_desc->RATRIndex = 0;
} }
...@@ -553,11 +539,9 @@ static void ieee80211_query_seqnum(struct ieee80211_device *ieee, ...@@ -553,11 +539,9 @@ static void ieee80211_query_seqnum(struct ieee80211_device *ieee,
{ {
if (is_multicast_ether_addr(dst)) if (is_multicast_ether_addr(dst))
return; return;
if (IsQoSDataFrame(skb->data)) //we deal qos data only if (IsQoSDataFrame(skb->data)) /* we deal qos data only */ {
{
struct tx_ts_record *pTS = NULL; struct tx_ts_record *pTS = NULL;
if (!GetTs(ieee, (struct ts_common_info **)(&pTS), dst, skb->priority, TX_DIR, true)) if (!GetTs(ieee, (struct ts_common_info **)(&pTS), dst, skb->priority, TX_DIR, true)) {
{
return; return;
} }
pTS->tx_cur_seq = (pTS->tx_cur_seq + 1) % 4096; pTS->tx_cur_seq = (pTS->tx_cur_seq + 1) % 4096;
...@@ -749,15 +733,13 @@ int ieee80211_xmit(struct sk_buff *skb, struct net_device *dev) ...@@ -749,15 +733,13 @@ int ieee80211_xmit(struct sk_buff *skb, struct net_device *dev)
} }
skb_reserve(skb_frag, ieee->tx_headroom); skb_reserve(skb_frag, ieee->tx_headroom);
if (encrypt){ if (encrypt) {
if (ieee->hwsec_active) if (ieee->hwsec_active)
tcb_desc->bHwSec = 1; tcb_desc->bHwSec = 1;
else else
tcb_desc->bHwSec = 0; tcb_desc->bHwSec = 0;
skb_reserve(skb_frag, crypt->ops->extra_prefix_len); skb_reserve(skb_frag, crypt->ops->extra_prefix_len);
} } else {
else
{
tcb_desc->bHwSec = 0; tcb_desc->bHwSec = 0;
} }
frag_hdr = skb_put_data(skb_frag, &header, hdr_len); frag_hdr = skb_put_data(skb_frag, &header, hdr_len);
...@@ -775,8 +757,7 @@ int ieee80211_xmit(struct sk_buff *skb, struct net_device *dev) ...@@ -775,8 +757,7 @@ int ieee80211_xmit(struct sk_buff *skb, struct net_device *dev)
bytes = bytes_last_frag; bytes = bytes_last_frag;
} }
//if(ieee->current_network.QoS_Enable) //if(ieee->current_network.QoS_Enable)
if(qos_actived) if(qos_actived) {
{
// add 1 only indicate to corresponding seq number control 2006/7/12 // add 1 only indicate to corresponding seq number control 2006/7/12
frag_hdr->seq_ctl = cpu_to_le16(ieee->seq_ctrl[UP2AC(skb->priority)+1]<<4 | i); frag_hdr->seq_ctl = cpu_to_le16(ieee->seq_ctrl[UP2AC(skb->priority)+1]<<4 | i);
} else { } else {
...@@ -806,17 +787,16 @@ int ieee80211_xmit(struct sk_buff *skb, struct net_device *dev) ...@@ -806,17 +787,16 @@ int ieee80211_xmit(struct sk_buff *skb, struct net_device *dev)
skb_put(skb_frag, 4); skb_put(skb_frag, 4);
} }
if(qos_actived) if (qos_actived) {
{ if (ieee->seq_ctrl[UP2AC(skb->priority) + 1] == 0xFFF)
if (ieee->seq_ctrl[UP2AC(skb->priority) + 1] == 0xFFF) ieee->seq_ctrl[UP2AC(skb->priority) + 1] = 0;
ieee->seq_ctrl[UP2AC(skb->priority) + 1] = 0; else
else ieee->seq_ctrl[UP2AC(skb->priority) + 1]++;
ieee->seq_ctrl[UP2AC(skb->priority) + 1]++;
} else { } else {
if (ieee->seq_ctrl[0] == 0xFFF) if (ieee->seq_ctrl[0] == 0xFFF)
ieee->seq_ctrl[0] = 0; ieee->seq_ctrl[0] = 0;
else else
ieee->seq_ctrl[0]++; ieee->seq_ctrl[0]++;
} }
} else { } else {
if (unlikely(skb->len < sizeof(struct rtl_80211_hdr_3addr))) { if (unlikely(skb->len < sizeof(struct rtl_80211_hdr_3addr))) {
...@@ -839,8 +819,7 @@ int ieee80211_xmit(struct sk_buff *skb, struct net_device *dev) ...@@ -839,8 +819,7 @@ int ieee80211_xmit(struct sk_buff *skb, struct net_device *dev)
success: success:
//WB add to fill data tcb_desc here. only first fragment is considered, need to change, and you may remove to other place. //WB add to fill data tcb_desc here. only first fragment is considered, need to change, and you may remove to other place.
if (txb) if (txb) {
{
struct cb_desc *tcb_desc = (struct cb_desc *)(txb->fragments[0]->cb + MAX_DEV_ADDR_SIZE); struct cb_desc *tcb_desc = (struct cb_desc *)(txb->fragments[0]->cb + MAX_DEV_ADDR_SIZE);
tcb_desc->bTxEnableFwCalcDur = 1; tcb_desc->bTxEnableFwCalcDur = 1;
if (is_multicast_ether_addr(header.addr1)) if (is_multicast_ether_addr(header.addr1))
......
...@@ -130,8 +130,7 @@ static inline char *rtl819x_translate_scan(struct ieee80211_device *ieee, ...@@ -130,8 +130,7 @@ static inline char *rtl819x_translate_scan(struct ieee80211_device *ieee,
max_rate = rate; max_rate = rate;
} }
if (network->mode >= IEEE_N_24G)//add N rate here; if (network->mode >= IEEE_N_24G) /* add N rate here */ {
{
struct ht_capability_ele *ht_cap = NULL; struct ht_capability_ele *ht_cap = NULL;
bool is40M = false, isShortGI = false; bool is40M = false, isShortGI = false;
u8 max_mcs = 0; u8 max_mcs = 0;
......
...@@ -273,8 +273,7 @@ typedef enum _HT_AGGRE_SIZE { ...@@ -273,8 +273,7 @@ typedef enum _HT_AGGRE_SIZE {
}HT_AGGRE_SIZE_E, *PHT_AGGRE_SIZE_E; }HT_AGGRE_SIZE_E, *PHT_AGGRE_SIZE_E;
/* Indicate different AP vendor for IOT issue */ /* Indicate different AP vendor for IOT issue */
typedef enum _HT_IOT_PEER typedef enum _HT_IOT_PEER {
{
HT_IOT_PEER_UNKNOWN = 0, HT_IOT_PEER_UNKNOWN = 0,
HT_IOT_PEER_REALTEK = 1, HT_IOT_PEER_REALTEK = 1,
HT_IOT_PEER_BROADCOM = 2, HT_IOT_PEER_BROADCOM = 2,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment