Commit eecf6deb authored by Alex Elder's avatar Alex Elder Committed by Greg Kroah-Hartman

greybus: get rid of greybus_gbuf_finished()

All greybus_gbuf_finished() does is call the gbuf's complete method.
Currently, greybus_gbuf_finished() is only ever called in one place,
and that place can call the complete method directly instead.  That
allows us to eliminate greybus_gbuf_finished().
Signed-off-by: default avatarAlex Elder <elder@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <greg@kroah.com>
parent a77b0680
...@@ -128,13 +128,6 @@ void greybus_cport_in(struct greybus_host_device *hd, u16 cport_id, ...@@ -128,13 +128,6 @@ void greybus_cport_in(struct greybus_host_device *hd, u16 cport_id,
} }
EXPORT_SYMBOL_GPL(greybus_cport_in); EXPORT_SYMBOL_GPL(greybus_cport_in);
/* Can be called in interrupt context, do the work and get out of here */
void greybus_gbuf_finished(struct gbuf *gbuf)
{
gbuf->complete(gbuf);
}
EXPORT_SYMBOL_GPL(greybus_gbuf_finished);
int gb_gbuf_init(void) int gb_gbuf_init(void)
{ {
gbuf_head_cache = kmem_cache_create("gbuf_head_cache", gbuf_head_cache = kmem_cache_create("gbuf_head_cache",
......
...@@ -191,7 +191,6 @@ struct greybus_host_device *greybus_create_hd(struct greybus_host_driver *hd, ...@@ -191,7 +191,6 @@ struct greybus_host_device *greybus_create_hd(struct greybus_host_driver *hd,
void greybus_remove_hd(struct greybus_host_device *hd); void greybus_remove_hd(struct greybus_host_device *hd);
void greybus_cport_in(struct greybus_host_device *hd, u16 cport_id, void greybus_cport_in(struct greybus_host_device *hd, u16 cport_id,
u8 *data, size_t length); u8 *data, size_t length);
void greybus_gbuf_finished(struct gbuf *gbuf);
struct gbuf *greybus_alloc_gbuf(struct gb_operation *operation, struct gbuf *greybus_alloc_gbuf(struct gb_operation *operation,
gbuf_complete_t complete, unsigned int size, gbuf_complete_t complete, unsigned int size,
......
...@@ -207,6 +207,7 @@ static void gb_operation_request_handle(struct gb_operation *operation) ...@@ -207,6 +207,7 @@ static void gb_operation_request_handle(struct gb_operation *operation)
static void gb_operation_recv_work(struct work_struct *recv_work) static void gb_operation_recv_work(struct work_struct *recv_work)
{ {
struct gb_operation *operation; struct gb_operation *operation;
struct gbuf *gbuf;
bool incoming_request; bool incoming_request;
operation = container_of(recv_work, struct gb_operation, recv_work); operation = container_of(recv_work, struct gb_operation, recv_work);
...@@ -217,9 +218,10 @@ static void gb_operation_recv_work(struct work_struct *recv_work) ...@@ -217,9 +218,10 @@ static void gb_operation_recv_work(struct work_struct *recv_work)
/* We're finished with the buffer we read into */ /* We're finished with the buffer we read into */
if (incoming_request) if (incoming_request)
greybus_gbuf_finished(operation->request); gbuf = operation->request;
else else
greybus_gbuf_finished(operation->response); gbuf = operation->response;
gbuf->complete(gbuf);
} }
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment