Commit ef179366 authored by Danilo Krummrich's avatar Danilo Krummrich Committed by Rob Herring

dt-bindings: ps2-gpio: document bus signals open drain

The PS/2 bus defines data and clock line to be open drain, this should
be reflected in the gpio flags set in the binding.

Especially, this is important since the clock line sometimes is driven
by the host while being used as interrupt source.
Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: default avatarDanilo Krummrich <danilokrummrich@dk-develop.de>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarRob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20220529132638.13420-2-danilokrummrich@dk-develop.de
parent 442feb31
...@@ -15,12 +15,18 @@ properties: ...@@ -15,12 +15,18 @@ properties:
data-gpios: data-gpios:
description: description:
the gpio used for the data signal the gpio used for the data signal - this should be flagged as
active high using open drain with (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)
from <dt-bindings/gpio/gpio.h> since the signal is open drain by
definition
maxItems: 1 maxItems: 1
clk-gpios: clk-gpios:
description: description:
the gpio used for the clock signal the gpio used for the clock signal - this should be flagged as
active high using open drain with (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)
from <dt-bindings/gpio/gpio.h> since the signal is open drain by
definition
maxItems: 1 maxItems: 1
interrupts: interrupts:
...@@ -52,7 +58,7 @@ examples: ...@@ -52,7 +58,7 @@ examples:
compatible = "ps2-gpio"; compatible = "ps2-gpio";
interrupt-parent = <&gpio>; interrupt-parent = <&gpio>;
interrupts = <23 IRQ_TYPE_EDGE_FALLING>; interrupts = <23 IRQ_TYPE_EDGE_FALLING>;
data-gpios = <&gpio 24 GPIO_ACTIVE_HIGH>; data-gpios = <&gpio 24 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
clk-gpios = <&gpio 23 GPIO_ACTIVE_HIGH>; clk-gpios = <&gpio 23 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
write-enable; write-enable;
}; };
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment