Commit ef4f527c authored by Kevin Cernekee's avatar Kevin Cernekee Committed by Greg Kroah-Hartman

tty: Fix comments that reference BKL, eventd, old paths

Signed-off-by: default avatarKevin Cernekee <cernekee@gmail.com>
Acked-by: default avatarAlan Cox <alan@linux.intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a205a56d
...@@ -1309,9 +1309,10 @@ static void uart_set_termios(struct tty_struct *tty, ...@@ -1309,9 +1309,10 @@ static void uart_set_termios(struct tty_struct *tty,
} }
/* /*
* In 2.4.5, calls to this will be serialized via the BKL in * Calls to uart_close() are serialised via the tty_lock in
* linux/drivers/char/tty_io.c:tty_release() * drivers/tty/tty_io.c:tty_release()
* linux/drivers/char/tty_io.c:do_tty_handup() * drivers/tty/tty_io.c:do_tty_hangup()
* This runs from a workqueue and can sleep for a _short_ time only.
*/ */
static void uart_close(struct tty_struct *tty, struct file *filp) static void uart_close(struct tty_struct *tty, struct file *filp)
{ {
...@@ -1438,10 +1439,9 @@ static void uart_wait_until_sent(struct tty_struct *tty, int timeout) ...@@ -1438,10 +1439,9 @@ static void uart_wait_until_sent(struct tty_struct *tty, int timeout)
} }
/* /*
* This is called with the BKL held in * Calls to uart_hangup() are serialised by the tty_lock in
* linux/drivers/char/tty_io.c:do_tty_hangup() * drivers/tty/tty_io.c:do_tty_hangup()
* We're called from the eventd thread, so we can sleep for * This runs from a workqueue and can sleep for a _short_ time only.
* a _short_ time only.
*/ */
static void uart_hangup(struct tty_struct *tty) static void uart_hangup(struct tty_struct *tty)
{ {
...@@ -1522,8 +1522,8 @@ static void uart_dtr_rts(struct tty_port *port, int onoff) ...@@ -1522,8 +1522,8 @@ static void uart_dtr_rts(struct tty_port *port, int onoff)
} }
/* /*
* calls to uart_open are serialised by the BKL in * Calls to uart_open are serialised by the tty_lock in
* fs/char_dev.c:chrdev_open() * drivers/tty/tty_io.c:tty_open()
* Note that if this fails, then uart_close() _will_ be called. * Note that if this fails, then uart_close() _will_ be called.
* *
* In time, we want to scrap the "opening nonpresent ports" * In time, we want to scrap the "opening nonpresent ports"
......
...@@ -536,7 +536,7 @@ EXPORT_SYMBOL_GPL(tty_wakeup); ...@@ -536,7 +536,7 @@ EXPORT_SYMBOL_GPL(tty_wakeup);
* __tty_hangup - actual handler for hangup events * __tty_hangup - actual handler for hangup events
* @work: tty device * @work: tty device
* *
* This can be called by the "eventd" kernel thread. That is process * This can be called by a "kworker" kernel thread. That is process
* synchronous but doesn't hold any locks, so we need to make sure we * synchronous but doesn't hold any locks, so we need to make sure we
* have the appropriate locks for what we're doing. * have the appropriate locks for what we're doing.
* *
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment