Commit ef707b83 authored by Holger Schurig's avatar Holger Schurig Committed by John W. Linville

libertas: before sleeping, check for a command result

If we don't check for a command response early, but rather sleep,
then we might sleep despite an already-received command response.
This will lead to a command-timeout.
Signed-off-by: default avatarHolger Schurig <hs4233@mail.mn-solutions.de>
Acked-by: default avatarDan Williams <dcbw@redhat.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent df349f9f
...@@ -722,14 +722,14 @@ static int lbs_thread(void *data) ...@@ -722,14 +722,14 @@ static int lbs_thread(void *data)
shouldsleep = 1; /* Something is en route to the device already */ shouldsleep = 1; /* Something is en route to the device already */
else if (priv->tx_pending_len > 0) else if (priv->tx_pending_len > 0)
shouldsleep = 0; /* We've a packet to send */ shouldsleep = 0; /* We've a packet to send */
else if (priv->resp_len[priv->resp_idx])
shouldsleep = 0; /* We have a command response */
else if (priv->cur_cmd) else if (priv->cur_cmd)
shouldsleep = 1; /* Can't send a command; one already running */ shouldsleep = 1; /* Can't send a command; one already running */
else if (!list_empty(&priv->cmdpendingq)) else if (!list_empty(&priv->cmdpendingq))
shouldsleep = 0; /* We have a command to send */ shouldsleep = 0; /* We have a command to send */
else if (__kfifo_len(priv->event_fifo)) else if (__kfifo_len(priv->event_fifo))
shouldsleep = 0; /* We have an event to process */ shouldsleep = 0; /* We have an event to process */
else if (priv->resp_len[priv->resp_idx])
shouldsleep = 0; /* We have a command response */
else else
shouldsleep = 1; /* No command */ shouldsleep = 1; /* No command */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment