Commit efe2178d authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Mark Brown

ASoC: mediatek: mt8173-rt5650: Fix refcount leak in mt8173_rt5650_dev_probe

of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Fix refcount leak in some error paths.

Fixes: 0f83f929 ("ASoC: mediatek: Add machine driver for ALC5650 codec")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220603124243.31358-1-linmq006@gmail.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent e6f08af6
...@@ -280,7 +280,8 @@ static int mt8173_rt5650_dev_probe(struct platform_device *pdev) ...@@ -280,7 +280,8 @@ static int mt8173_rt5650_dev_probe(struct platform_device *pdev)
if (!mt8173_rt5650_dais[DAI_LINK_CODEC_I2S].codecs[0].of_node) { if (!mt8173_rt5650_dais[DAI_LINK_CODEC_I2S].codecs[0].of_node) {
dev_err(&pdev->dev, dev_err(&pdev->dev,
"Property 'audio-codec' missing or invalid\n"); "Property 'audio-codec' missing or invalid\n");
return -EINVAL; ret = -EINVAL;
goto put_platform_node;
} }
mt8173_rt5650_dais[DAI_LINK_CODEC_I2S].codecs[1].of_node = mt8173_rt5650_dais[DAI_LINK_CODEC_I2S].codecs[1].of_node =
mt8173_rt5650_dais[DAI_LINK_CODEC_I2S].codecs[0].of_node; mt8173_rt5650_dais[DAI_LINK_CODEC_I2S].codecs[0].of_node;
...@@ -293,7 +294,7 @@ static int mt8173_rt5650_dev_probe(struct platform_device *pdev) ...@@ -293,7 +294,7 @@ static int mt8173_rt5650_dev_probe(struct platform_device *pdev)
dev_err(&pdev->dev, dev_err(&pdev->dev,
"%s codec_capture_dai name fail %d\n", "%s codec_capture_dai name fail %d\n",
__func__, ret); __func__, ret);
return ret; goto put_platform_node;
} }
mt8173_rt5650_dais[DAI_LINK_CODEC_I2S].codecs[1].dai_name = mt8173_rt5650_dais[DAI_LINK_CODEC_I2S].codecs[1].dai_name =
codec_capture_dai; codec_capture_dai;
...@@ -315,12 +316,14 @@ static int mt8173_rt5650_dev_probe(struct platform_device *pdev) ...@@ -315,12 +316,14 @@ static int mt8173_rt5650_dev_probe(struct platform_device *pdev)
if (!mt8173_rt5650_dais[DAI_LINK_HDMI_I2S].codecs->of_node) { if (!mt8173_rt5650_dais[DAI_LINK_HDMI_I2S].codecs->of_node) {
dev_err(&pdev->dev, dev_err(&pdev->dev,
"Property 'audio-codec' missing or invalid\n"); "Property 'audio-codec' missing or invalid\n");
return -EINVAL; ret = -EINVAL;
goto put_platform_node;
} }
card->dev = &pdev->dev; card->dev = &pdev->dev;
ret = devm_snd_soc_register_card(&pdev->dev, card); ret = devm_snd_soc_register_card(&pdev->dev, card);
put_platform_node:
of_node_put(platform_node); of_node_put(platform_node);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment