Commit f0a8afec authored by Bart Van Assche's avatar Bart Van Assche Committed by Nicholas Bellinger

target: Fix a memory leak in target_dev_lba_map_store()

strsep() modifies its first argument. Make the pointer passed to kfree()
match the return value of kmalloc().

Fixes: 229d4f11 (commit "target_core_alua: Referrals configfs integration")
Signed-off-by: default avatarBart Van Assche <bart.vanassche@sandisk.com>
Cc: Hannes Reinecke <hare@suse.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Andy Grover <agrover@redhat.com>
Cc: Sagi Grimberg <sagig@mellanox.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 5261d86c
...@@ -2017,14 +2017,14 @@ static ssize_t target_dev_lba_map_store(struct config_item *item, ...@@ -2017,14 +2017,14 @@ static ssize_t target_dev_lba_map_store(struct config_item *item,
struct se_device *dev = to_device(item); struct se_device *dev = to_device(item);
struct t10_alua_lba_map *lba_map = NULL; struct t10_alua_lba_map *lba_map = NULL;
struct list_head lba_list; struct list_head lba_list;
char *map_entries, *ptr; char *map_entries, *orig, *ptr;
char state; char state;
int pg_num = -1, pg; int pg_num = -1, pg;
int ret = 0, num = 0, pg_id, alua_state; int ret = 0, num = 0, pg_id, alua_state;
unsigned long start_lba = -1, end_lba = -1; unsigned long start_lba = -1, end_lba = -1;
unsigned long segment_size = -1, segment_mult = -1; unsigned long segment_size = -1, segment_mult = -1;
map_entries = kstrdup(page, GFP_KERNEL); orig = map_entries = kstrdup(page, GFP_KERNEL);
if (!map_entries) if (!map_entries)
return -ENOMEM; return -ENOMEM;
...@@ -2122,7 +2122,7 @@ static ssize_t target_dev_lba_map_store(struct config_item *item, ...@@ -2122,7 +2122,7 @@ static ssize_t target_dev_lba_map_store(struct config_item *item,
} else } else
core_alua_set_lba_map(dev, &lba_list, core_alua_set_lba_map(dev, &lba_list,
segment_size, segment_mult); segment_size, segment_mult);
kfree(map_entries); kfree(orig);
return count; return count;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment