Commit f0d9d0f4 authored by Matthew McClintock's avatar Matthew McClintock Committed by Wim Van Sebroeck

watchdog: qcom: add option for standalone watchdog not in timer block

Commit 0dfd582e ("watchdog: qcom: use timer devicetree
binding") moved to use the watchdog as a subset timer
register block. Some devices have the watchdog completely
standalone with slightly different register offsets as
well so let's account for the differences here.

The existing "kpss-standalone" compatible string doesn't
make it entirely clear exactly what the device is so
rename to "kpss-wdt" to reflect watchdog timer
functionality. Also update ipq4019 DTS with an SoC
specific compatible.
Signed-off-by: default avatarMatthew McClintock <mmcclint@codeaurora.org>
Signed-off-by: default avatarThomas Pedersen <twp@codeaurora.org>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarWim Van Sebroeck <wim@iguana.be>
parent 6e062696
...@@ -7,8 +7,10 @@ Required properties : ...@@ -7,8 +7,10 @@ Required properties :
"qcom,kpss-wdt-msm8960" "qcom,kpss-wdt-msm8960"
"qcom,kpss-wdt-apq8064" "qcom,kpss-wdt-apq8064"
"qcom,kpss-wdt-ipq8064" "qcom,kpss-wdt-ipq8064"
"qcom,kpss-wdt-ipq4019"
"qcom,kpss-timer" "qcom,kpss-timer"
"qcom,scss-timer" "qcom,scss-timer"
"qcom,kpss-wdt"
- reg : shall contain base register location and length - reg : shall contain base register location and length
- clocks : shall contain the input clock - clocks : shall contain the input clock
......
...@@ -252,7 +252,7 @@ serial@78b0000 { ...@@ -252,7 +252,7 @@ serial@78b0000 {
}; };
watchdog@b017000 { watchdog@b017000 {
compatible = "qcom,kpss-standalone"; compatible = "qcom,kpss-wdt", "qcom,kpss-wdt-ipq4019";
reg = <0xb017000 0x40>; reg = <0xb017000 0x40>;
clocks = <&sleep_clk>; clocks = <&sleep_clk>;
timeout-sec = <10>; timeout-sec = <10>;
......
...@@ -18,19 +18,42 @@ ...@@ -18,19 +18,42 @@
#include <linux/of.h> #include <linux/of.h>
#include <linux/platform_device.h> #include <linux/platform_device.h>
#include <linux/watchdog.h> #include <linux/watchdog.h>
#include <linux/of_device.h>
#define WDT_RST 0x38 enum wdt_reg {
#define WDT_EN 0x40 WDT_RST,
#define WDT_STS 0x44 WDT_EN,
#define WDT_BITE_TIME 0x5C WDT_STS,
WDT_BITE_TIME,
};
static const u32 reg_offset_data_apcs_tmr[] = {
[WDT_RST] = 0x38,
[WDT_EN] = 0x40,
[WDT_STS] = 0x44,
[WDT_BITE_TIME] = 0x5C,
};
static const u32 reg_offset_data_kpss[] = {
[WDT_RST] = 0x4,
[WDT_EN] = 0x8,
[WDT_STS] = 0xC,
[WDT_BITE_TIME] = 0x14,
};
struct qcom_wdt { struct qcom_wdt {
struct watchdog_device wdd; struct watchdog_device wdd;
struct clk *clk; struct clk *clk;
unsigned long rate; unsigned long rate;
void __iomem *base; void __iomem *base;
const u32 *layout;
}; };
static void __iomem *wdt_addr(struct qcom_wdt *wdt, enum wdt_reg reg)
{
return wdt->base + wdt->layout[reg];
}
static inline static inline
struct qcom_wdt *to_qcom_wdt(struct watchdog_device *wdd) struct qcom_wdt *to_qcom_wdt(struct watchdog_device *wdd)
{ {
...@@ -41,10 +64,10 @@ static int qcom_wdt_start(struct watchdog_device *wdd) ...@@ -41,10 +64,10 @@ static int qcom_wdt_start(struct watchdog_device *wdd)
{ {
struct qcom_wdt *wdt = to_qcom_wdt(wdd); struct qcom_wdt *wdt = to_qcom_wdt(wdd);
writel(0, wdt->base + WDT_EN); writel(0, wdt_addr(wdt, WDT_EN));
writel(1, wdt->base + WDT_RST); writel(1, wdt_addr(wdt, WDT_RST));
writel(wdd->timeout * wdt->rate, wdt->base + WDT_BITE_TIME); writel(wdd->timeout * wdt->rate, wdt_addr(wdt, WDT_BITE_TIME));
writel(1, wdt->base + WDT_EN); writel(1, wdt_addr(wdt, WDT_EN));
return 0; return 0;
} }
...@@ -52,7 +75,7 @@ static int qcom_wdt_stop(struct watchdog_device *wdd) ...@@ -52,7 +75,7 @@ static int qcom_wdt_stop(struct watchdog_device *wdd)
{ {
struct qcom_wdt *wdt = to_qcom_wdt(wdd); struct qcom_wdt *wdt = to_qcom_wdt(wdd);
writel(0, wdt->base + WDT_EN); writel(0, wdt_addr(wdt, WDT_EN));
return 0; return 0;
} }
...@@ -60,7 +83,7 @@ static int qcom_wdt_ping(struct watchdog_device *wdd) ...@@ -60,7 +83,7 @@ static int qcom_wdt_ping(struct watchdog_device *wdd)
{ {
struct qcom_wdt *wdt = to_qcom_wdt(wdd); struct qcom_wdt *wdt = to_qcom_wdt(wdd);
writel(1, wdt->base + WDT_RST); writel(1, wdt_addr(wdt, WDT_RST));
return 0; return 0;
} }
...@@ -83,10 +106,10 @@ static int qcom_wdt_restart(struct watchdog_device *wdd, unsigned long action, ...@@ -83,10 +106,10 @@ static int qcom_wdt_restart(struct watchdog_device *wdd, unsigned long action,
*/ */
timeout = 128 * wdt->rate / 1000; timeout = 128 * wdt->rate / 1000;
writel(0, wdt->base + WDT_EN); writel(0, wdt_addr(wdt, WDT_EN));
writel(1, wdt->base + WDT_RST); writel(1, wdt_addr(wdt, WDT_RST));
writel(timeout, wdt->base + WDT_BITE_TIME); writel(timeout, wdt_addr(wdt, WDT_BITE_TIME));
writel(1, wdt->base + WDT_EN); writel(1, wdt_addr(wdt, WDT_EN));
/* /*
* Actually make sure the above sequence hits hardware before sleeping. * Actually make sure the above sequence hits hardware before sleeping.
...@@ -119,9 +142,16 @@ static int qcom_wdt_probe(struct platform_device *pdev) ...@@ -119,9 +142,16 @@ static int qcom_wdt_probe(struct platform_device *pdev)
struct qcom_wdt *wdt; struct qcom_wdt *wdt;
struct resource *res; struct resource *res;
struct device_node *np = pdev->dev.of_node; struct device_node *np = pdev->dev.of_node;
const u32 *regs;
u32 percpu_offset; u32 percpu_offset;
int ret; int ret;
regs = of_device_get_match_data(&pdev->dev);
if (!regs) {
dev_err(&pdev->dev, "Unsupported QCOM WDT module\n");
return -ENODEV;
}
wdt = devm_kzalloc(&pdev->dev, sizeof(*wdt), GFP_KERNEL); wdt = devm_kzalloc(&pdev->dev, sizeof(*wdt), GFP_KERNEL);
if (!wdt) if (!wdt)
return -ENOMEM; return -ENOMEM;
...@@ -172,6 +202,7 @@ static int qcom_wdt_probe(struct platform_device *pdev) ...@@ -172,6 +202,7 @@ static int qcom_wdt_probe(struct platform_device *pdev)
wdt->wdd.min_timeout = 1; wdt->wdd.min_timeout = 1;
wdt->wdd.max_timeout = 0x10000000U / wdt->rate; wdt->wdd.max_timeout = 0x10000000U / wdt->rate;
wdt->wdd.parent = &pdev->dev; wdt->wdd.parent = &pdev->dev;
wdt->layout = regs;
if (readl(wdt->base + WDT_STS) & 1) if (readl(wdt->base + WDT_STS) & 1)
wdt->wdd.bootstatus = WDIOF_CARDRESET; wdt->wdd.bootstatus = WDIOF_CARDRESET;
...@@ -208,8 +239,9 @@ static int qcom_wdt_remove(struct platform_device *pdev) ...@@ -208,8 +239,9 @@ static int qcom_wdt_remove(struct platform_device *pdev)
} }
static const struct of_device_id qcom_wdt_of_table[] = { static const struct of_device_id qcom_wdt_of_table[] = {
{ .compatible = "qcom,kpss-timer" }, { .compatible = "qcom,kpss-timer", .data = reg_offset_data_apcs_tmr },
{ .compatible = "qcom,scss-timer" }, { .compatible = "qcom,scss-timer", .data = reg_offset_data_apcs_tmr },
{ .compatible = "qcom,kpss-wdt", .data = reg_offset_data_kpss },
{ }, { },
}; };
MODULE_DEVICE_TABLE(of, qcom_wdt_of_table); MODULE_DEVICE_TABLE(of, qcom_wdt_of_table);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment