Commit f245860e authored by Daniel Vetter's avatar Daniel Vetter

drm/i915: Check locking in i915_gem_request_unreference

With refcounting it looks like you can just drop that refcount, but
that's not really the case. So make sure no one forgets.

Motivated by the unlocked call in the mmio flip code.

Cc: John Harrison <John.C.Harrison@Intel.com>
Cc: Thomas Daniel <Thomas.Daniel@intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
parent a4b3a571
...@@ -2046,6 +2046,7 @@ i915_gem_request_reference(struct drm_i915_gem_request *req) ...@@ -2046,6 +2046,7 @@ i915_gem_request_reference(struct drm_i915_gem_request *req)
static inline void static inline void
i915_gem_request_unreference(struct drm_i915_gem_request *req) i915_gem_request_unreference(struct drm_i915_gem_request *req)
{ {
WARN_ON(!mutex_is_locked(&req->ring->dev->struct_mutex));
kref_put(&req->ref, i915_gem_request_free); kref_put(&req->ref, i915_gem_request_free);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment