Commit f2916c83 authored by Mengyuan Lou's avatar Mengyuan Lou Committed by Paolo Abeni

net: ngbe: Fix phy mode set to external phy

The MAC only has add the TX delay and it can not be modified.
MAC and PHY are both set the TX delay cause transmission problems.
So just disable TX delay in PHY, when use rgmii to attach to
external phy, set PHY_INTERFACE_MODE_RGMII_RXID to phy drivers.
And it is does not matter to internal phy.

Fixes: bc2426d7 ("net: ngbe: convert phylib to phylink")
Signed-off-by: default avatarMengyuan Lou <mengyuanlou@net-swift.com>
Cc: stable@vger.kernel.org # 6.3+
Reviewed-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/E6759CF1387CF84C+20240820030425.93003-1-mengyuanlou@net-swift.comSigned-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent a0b4a80e
...@@ -124,8 +124,12 @@ static int ngbe_phylink_init(struct wx *wx) ...@@ -124,8 +124,12 @@ static int ngbe_phylink_init(struct wx *wx)
MAC_SYM_PAUSE | MAC_ASYM_PAUSE; MAC_SYM_PAUSE | MAC_ASYM_PAUSE;
config->mac_managed_pm = true; config->mac_managed_pm = true;
phy_mode = PHY_INTERFACE_MODE_RGMII_ID; /* The MAC only has add the Tx delay and it can not be modified.
__set_bit(PHY_INTERFACE_MODE_RGMII_ID, config->supported_interfaces); * So just disable TX delay in PHY, and it is does not matter to
* internal phy.
*/
phy_mode = PHY_INTERFACE_MODE_RGMII_RXID;
__set_bit(PHY_INTERFACE_MODE_RGMII_RXID, config->supported_interfaces);
phylink = phylink_create(config, NULL, phy_mode, &ngbe_mac_ops); phylink = phylink_create(config, NULL, phy_mode, &ngbe_mac_ops);
if (IS_ERR(phylink)) if (IS_ERR(phylink))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment