Commit f2daa466 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Mark Brown

spi: Use sysfs_emit() to instead of s*printf()

Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230710154932.68377-7-andriy.shevchenko@linux.intel.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 2b308e71
...@@ -64,7 +64,7 @@ modalias_show(struct device *dev, struct device_attribute *a, char *buf) ...@@ -64,7 +64,7 @@ modalias_show(struct device *dev, struct device_attribute *a, char *buf)
if (len != -ENODEV) if (len != -ENODEV)
return len; return len;
return sprintf(buf, "%s%s\n", SPI_MODULE_PREFIX, spi->modalias); return sysfs_emit(buf, "%s%s\n", SPI_MODULE_PREFIX, spi->modalias);
} }
static DEVICE_ATTR_RO(modalias); static DEVICE_ATTR_RO(modalias);
...@@ -89,7 +89,7 @@ static ssize_t driver_override_show(struct device *dev, ...@@ -89,7 +89,7 @@ static ssize_t driver_override_show(struct device *dev,
ssize_t len; ssize_t len;
device_lock(dev); device_lock(dev);
len = snprintf(buf, PAGE_SIZE, "%s\n", spi->driver_override ? : ""); len = sysfs_emit(buf, "%s\n", spi->driver_override ? : "");
device_unlock(dev); device_unlock(dev);
return len; return len;
} }
...@@ -2814,8 +2814,7 @@ static ssize_t slave_show(struct device *dev, struct device_attribute *attr, ...@@ -2814,8 +2814,7 @@ static ssize_t slave_show(struct device *dev, struct device_attribute *attr,
struct device *child; struct device *child;
child = device_find_any_child(&ctlr->dev); child = device_find_any_child(&ctlr->dev);
return sprintf(buf, "%s\n", return sysfs_emit(buf, "%s\n", child ? to_spi_device(child)->modalias : NULL);
child ? to_spi_device(child)->modalias : NULL);
} }
static ssize_t slave_store(struct device *dev, struct device_attribute *attr, static ssize_t slave_store(struct device *dev, struct device_attribute *attr,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment