Commit f2edd9f6 authored by Sebastian Reichel's avatar Sebastian Reichel Committed by Marcel Holtmann

Bluetooth: hci_ll: Fix NULL pointer deref on FW upload failure

Avoid NULL pointer dereference occurring due to freeing
skb containing an error pointer. It can easily be triggered
by using the driver with broken uart (i.e. due to misconfigured
pinmuxing).

Fixes: 37180552 ("bluetooth: hci_uart: add LL protocol serdev driver support")
Signed-off-by: default avatarSebastian Reichel <sre@kernel.org>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent fb796707
...@@ -537,8 +537,7 @@ static int read_local_version(struct hci_dev *hdev) ...@@ -537,8 +537,7 @@ static int read_local_version(struct hci_dev *hdev)
if (IS_ERR(skb)) { if (IS_ERR(skb)) {
bt_dev_err(hdev, "Reading TI version information failed (%ld)", bt_dev_err(hdev, "Reading TI version information failed (%ld)",
PTR_ERR(skb)); PTR_ERR(skb));
err = PTR_ERR(skb); return PTR_ERR(skb);
goto out;
} }
if (skb->len != sizeof(*ver)) { if (skb->len != sizeof(*ver)) {
err = -EILSEQ; err = -EILSEQ;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment