Commit f3ba0534 authored by Jonathan Cameron's avatar Jonathan Cameron

iio:light:tcs3414: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr() etc

Letting the compiler remove these functions when the kernel is built
without CONFIG_PM_SLEEP support is simpler and less error prone than the
use of #ifdef based config guards.

Removing instances of this approach from IIO also stops them being
copied into new drivers.
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: default avatarPaul Cercueil <paul@crapouillou.net>
Link: https://lore.kernel.org/r/20220130193147.279148-26-jic23@kernel.org
parent 20cadda3
...@@ -345,7 +345,6 @@ static int tcs3414_probe(struct i2c_client *client, ...@@ -345,7 +345,6 @@ static int tcs3414_probe(struct i2c_client *client,
return devm_iio_device_register(&client->dev, indio_dev); return devm_iio_device_register(&client->dev, indio_dev);
} }
#ifdef CONFIG_PM_SLEEP
static int tcs3414_suspend(struct device *dev) static int tcs3414_suspend(struct device *dev)
{ {
struct tcs3414_data *data = iio_priv(i2c_get_clientdata( struct tcs3414_data *data = iio_priv(i2c_get_clientdata(
...@@ -360,9 +359,9 @@ static int tcs3414_resume(struct device *dev) ...@@ -360,9 +359,9 @@ static int tcs3414_resume(struct device *dev)
return i2c_smbus_write_byte_data(data->client, TCS3414_CONTROL, return i2c_smbus_write_byte_data(data->client, TCS3414_CONTROL,
data->control); data->control);
} }
#endif
static SIMPLE_DEV_PM_OPS(tcs3414_pm_ops, tcs3414_suspend, tcs3414_resume); static DEFINE_SIMPLE_DEV_PM_OPS(tcs3414_pm_ops, tcs3414_suspend,
tcs3414_resume);
static const struct i2c_device_id tcs3414_id[] = { static const struct i2c_device_id tcs3414_id[] = {
{ "tcs3414", 0 }, { "tcs3414", 0 },
...@@ -373,7 +372,7 @@ MODULE_DEVICE_TABLE(i2c, tcs3414_id); ...@@ -373,7 +372,7 @@ MODULE_DEVICE_TABLE(i2c, tcs3414_id);
static struct i2c_driver tcs3414_driver = { static struct i2c_driver tcs3414_driver = {
.driver = { .driver = {
.name = TCS3414_DRV_NAME, .name = TCS3414_DRV_NAME,
.pm = &tcs3414_pm_ops, .pm = pm_sleep_ptr(&tcs3414_pm_ops),
}, },
.probe = tcs3414_probe, .probe = tcs3414_probe,
.id_table = tcs3414_id, .id_table = tcs3414_id,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment