Commit f458c23a authored by Bjorn Helgaas's avatar Bjorn Helgaas Committed by Dave Jones

[AGP] Print AGP version & mode when programming devices.

parent e2373e27
...@@ -382,9 +382,6 @@ static void agp_x86_64_agp_enable(u32 mode) ...@@ -382,9 +382,6 @@ static void agp_x86_64_agp_enable(u32 mode)
* Ok, here we have a AGP device. Disable impossible * Ok, here we have a AGP device. Disable impossible
* settings, and adjust the readqueue to the minimum. * settings, and adjust the readqueue to the minimum.
*/ */
printk (KERN_INFO "AGP: Setting up AGPv3 capable device at %d:%d:%d\n",
device->bus->number, PCI_FUNC(device->devfn), PCI_SLOT(device->devfn));
pci_read_config_dword(device, cap_ptr + 4, &scratch); pci_read_config_dword(device, cap_ptr + 4, &scratch);
/* adjust RQ depth */ /* adjust RQ depth */
...@@ -402,15 +399,11 @@ static void agp_x86_64_agp_enable(u32 mode) ...@@ -402,15 +399,11 @@ static void agp_x86_64_agp_enable(u32 mode)
if (!((command & 0x10) && (scratch & 0x10) && (mode & 0x10))) if (!((command & 0x10) && (scratch & 0x10) && (mode & 0x10)))
command &= ~0x10; command &= ~0x10;
if (!((command & 2) && (scratch & 2) && (mode & 2))) { if (!((command & 2) && (scratch & 2) && (mode & 2)))
command &= ~2; /* 8x */ command &= ~2; /* 8x */
printk (KERN_INFO "AGP: Putting device into 8x mode\n");
}
if (!((command & 1) && (scratch & 1) && (mode & 1))) { if (!((command & 1) && (scratch & 1) && (mode & 1)))
command &= ~1; /* 4x */ command &= ~1; /* 4x */
printk (KERN_INFO "AGP: Putting device into 4x mode\n");
}
} }
} }
/* /*
...@@ -433,7 +426,7 @@ static void agp_x86_64_agp_enable(u32 mode) ...@@ -433,7 +426,7 @@ static void agp_x86_64_agp_enable(u32 mode)
* command registers. * command registers.
*/ */
agp_device_command(command); agp_device_command(command, 1);
} }
......
...@@ -314,15 +314,22 @@ int agp_unbind_memory(agp_memory * curr) ...@@ -314,15 +314,22 @@ int agp_unbind_memory(agp_memory * curr)
/* Generic Agp routines - Start */ /* Generic Agp routines - Start */
void agp_device_command(u32 command) void agp_device_command(u32 command, int agp_v3)
{ {
struct pci_dev *device; struct pci_dev *device;
int mode;
mode = command & 0x7;
if (agp_v3)
mode *= 4;
pci_for_each_dev(device) { pci_for_each_dev(device) {
u8 agp = pci_find_capability(device, PCI_CAP_ID_AGP); u8 agp = pci_find_capability(device, PCI_CAP_ID_AGP);
if (!agp) if (!agp)
continue; continue;
printk(KERN_INFO PFX "Putting AGP V%d device at %s into %dx mode\n",
agp_v3 ? 3 : 2, device->slot_name, mode);
pci_write_config_dword(device, agp + 8, command); pci_write_config_dword(device, agp + 8, command);
} }
} }
...@@ -409,7 +416,7 @@ void agp_generic_agp_enable(u32 mode) ...@@ -409,7 +416,7 @@ void agp_generic_agp_enable(u32 mode)
* command registers. * command registers.
*/ */
agp_device_command(command); agp_device_command(command, 0);
} }
int agp_generic_create_gatt_table(void) int agp_generic_create_gatt_table(void)
......
...@@ -496,7 +496,7 @@ static void serverworks_agp_enable(u32 mode) ...@@ -496,7 +496,7 @@ static void serverworks_agp_enable(u32 mode)
* command registers. * command registers.
*/ */
agp_device_command(command); agp_device_command(command, 0);
} }
static int __init serverworks_setup (struct pci_dev *pdev) static int __init serverworks_setup (struct pci_dev *pdev)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment