Commit f4c4e9ad authored by Hans de Goede's avatar Hans de Goede

platform/x86: dell-wmi-sysman: Fix release_attributes_data() getting called...

platform/x86: dell-wmi-sysman: Fix release_attributes_data() getting called twice on init_bios_attributes() failure

All calls of init_bios_attributes() will result in a
goto fail_create_group if they fail, which calls
release_attributes_data().

So there is no need to call release_attributes_data() from
init_bios_attributes() on failure itself.

Fixes: e8a60aa7 ("platform/x86: Introduce support for Systems Management Driver over WMI for Dell Systems")
Cc: Divya Bharathi <Divya_Bharathi@dell.com>
Cc: Mario Limonciello <mario.limonciello@dell.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20210321115901.35072-5-hdegoede@redhat.com
parent cb1e50f2
...@@ -491,7 +491,6 @@ static int init_bios_attributes(int attr_type, const char *guid) ...@@ -491,7 +491,6 @@ static int init_bios_attributes(int attr_type, const char *guid)
err_attr_init: err_attr_init:
mutex_unlock(&wmi_priv.mutex); mutex_unlock(&wmi_priv.mutex);
release_attributes_data();
kfree(obj); kfree(obj);
return retval; return retval;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment