Commit f4eedfd8 authored by Johannes Berg's avatar Johannes Berg

wifi: iwlwifi: mvm: expand queue sync warning messages

It's a bit tricky to understand what's going on here, add
more data to the warning messages to make that clearer.
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Reviewed-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: default avatarMiri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://msgid.link/20240205211151.1df82a509636.I2f71811569a5c48eb166c4caa779af2d6160ad33@changeidSigned-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 4d951e26
// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause // SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
/* /*
* Copyright (C) 2012-2014, 2018-2023 Intel Corporation * Copyright (C) 2012-2014, 2018-2024 Intel Corporation
* Copyright (C) 2013-2015 Intel Mobile Communications GmbH * Copyright (C) 2013-2015 Intel Mobile Communications GmbH
* Copyright (C) 2016-2017 Intel Deutschland GmbH * Copyright (C) 2016-2017 Intel Deutschland GmbH
*/ */
...@@ -6097,8 +6097,9 @@ void iwl_mvm_sync_rx_queues_internal(struct iwl_mvm *mvm, ...@@ -6097,8 +6097,9 @@ void iwl_mvm_sync_rx_queues_internal(struct iwl_mvm *mvm,
iwl_mvm_is_radio_killed(mvm), iwl_mvm_is_radio_killed(mvm),
HZ); HZ);
WARN_ONCE(!ret && !iwl_mvm_is_radio_killed(mvm), WARN_ONCE(!ret && !iwl_mvm_is_radio_killed(mvm),
"queue sync: failed to sync, state is 0x%lx\n", "queue sync: failed to sync, state is 0x%lx, cookie %d\n",
mvm->queue_sync_state); mvm->queue_sync_state,
mvm->queue_sync_cookie);
} }
out: out:
......
// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause // SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
/* /*
* Copyright (C) 2012-2014, 2018-2023 Intel Corporation * Copyright (C) 2012-2014, 2018-2024 Intel Corporation
* Copyright (C) 2013-2015 Intel Mobile Communications GmbH * Copyright (C) 2013-2015 Intel Mobile Communications GmbH
* Copyright (C) 2015-2017 Intel Deutschland GmbH * Copyright (C) 2015-2017 Intel Deutschland GmbH
*/ */
...@@ -688,11 +688,11 @@ void iwl_mvm_rx_queue_notif(struct iwl_mvm *mvm, struct napi_struct *napi, ...@@ -688,11 +688,11 @@ void iwl_mvm_rx_queue_notif(struct iwl_mvm *mvm, struct napi_struct *napi,
return; return;
len -= sizeof(*notif) + sizeof(*internal_notif); len -= sizeof(*notif) + sizeof(*internal_notif);
if (internal_notif->sync && if (WARN_ONCE(internal_notif->sync &&
mvm->queue_sync_cookie != internal_notif->cookie) { mvm->queue_sync_cookie != internal_notif->cookie,
WARN_ONCE(1, "Received expired RX queue sync message\n"); "Received expired RX queue sync message (cookie %d but wanted %d, queue %d)\n",
internal_notif->cookie, mvm->queue_sync_cookie, queue))
return; return;
}
switch (internal_notif->type) { switch (internal_notif->type) {
case IWL_MVM_RXQ_EMPTY: case IWL_MVM_RXQ_EMPTY:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment