Commit f5131257 authored by Stanislav Kinsbursky's avatar Stanislav Kinsbursky Committed by Trond Myklebust

SUNRPC: remove RPC client pipefs dentries after unregister

Without this patch we have races:

rpc_fill_super				rpc_free_client
rpc_pipefs_event(MOUNT)			rpc_remove_pipedir
spin_lock(&rpc_client_lock);
rpc_setup_pipedir_sb
spin_unlock(&rpc_client_lock);
					spin_lock(&rpc_client_lock);
					(remove from list)
					spin_unlock(&rpc_client_lock);
					MEAMORY LEAKED
Signed-off-by: default avatarStanislav Kinsbursky <skinsbursky@parallels.com>
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent 80df9d20
...@@ -578,7 +578,6 @@ rpc_free_client(struct rpc_clnt *clnt) ...@@ -578,7 +578,6 @@ rpc_free_client(struct rpc_clnt *clnt)
{ {
dprintk("RPC: destroying %s client for %s\n", dprintk("RPC: destroying %s client for %s\n",
clnt->cl_protname, clnt->cl_server); clnt->cl_protname, clnt->cl_server);
rpc_clnt_remove_pipedir(clnt);
if (clnt->cl_parent != clnt) { if (clnt->cl_parent != clnt) {
rpc_release_client(clnt->cl_parent); rpc_release_client(clnt->cl_parent);
goto out_free; goto out_free;
...@@ -587,6 +586,7 @@ rpc_free_client(struct rpc_clnt *clnt) ...@@ -587,6 +586,7 @@ rpc_free_client(struct rpc_clnt *clnt)
kfree(clnt->cl_server); kfree(clnt->cl_server);
out_free: out_free:
rpc_unregister_client(clnt); rpc_unregister_client(clnt);
rpc_clnt_remove_pipedir(clnt);
rpc_free_iostats(clnt->cl_metrics); rpc_free_iostats(clnt->cl_metrics);
kfree(clnt->cl_principal); kfree(clnt->cl_principal);
clnt->cl_metrics = NULL; clnt->cl_metrics = NULL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment