Commit f5c93dea authored by Bartosz Golaszewski's avatar Bartosz Golaszewski Committed by Greg Kroah-Hartman

greybus: pm: add error handling to bundle activation

The firmware now keeps the underlying hardware disabled until
receiving the first Bundle Activate request. Additionally: requesting
transition to a state the bundle is already in is no longer an error.

We can now add proper error handling to the bundle activate call.
Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
parent 2358024b
...@@ -181,12 +181,11 @@ static int greybus_probe(struct device *dev) ...@@ -181,12 +181,11 @@ static int greybus_probe(struct device *dev)
return retval; return retval;
} }
/* retval = gb_control_bundle_activate(bundle->intf->control, bundle->id);
* FIXME: We need to perform error handling on bundle activate call if (retval) {
* below when firmware is ready. We just allow the activate operation to pm_runtime_put(&bundle->intf->dev);
* fail for now since bundle may be in active already. return retval;
*/ }
gb_control_bundle_activate(bundle->intf->control, bundle->id);
/* /*
* Unbound bundle devices are always deactivated. During probe, the * Unbound bundle devices are always deactivated. During probe, the
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment