Commit f5dd8732 authored by Wen Yang's avatar Wen Yang Committed by Greg Kroah-Hartman

fpga: stratix10-soc: fix use-after-free on s10_init()

The refcount of fw_np has already been decreased by of_find_matching_node()
so it shouldn't be used anymore.
This patch adds an of_node_get() before of_find_matching_node() to avoid
the use-after-free problem.

Fixes: e7eef1d7 ("fpga: add intel stratix10 soc fpga manager driver")
Signed-off-by: default avatarWen Yang <wen.yang99@zte.com.cn>
Cc: Alan Tull <atull@kernel.org>
Cc: Moritz Fischer <mdf@kernel.org>
Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: linux-fpga@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Reviewed-by: default avatarMoritz Fischer <mdf@kernel.org>
Reviewed-by: default avatarNicolas Saenz Julienne <nsaenzjulienne@suse.de>
Acked-by: default avatarAlan Tull <atull@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 02bd610e
...@@ -507,12 +507,16 @@ static int __init s10_init(void) ...@@ -507,12 +507,16 @@ static int __init s10_init(void)
if (!fw_np) if (!fw_np)
return -ENODEV; return -ENODEV;
of_node_get(fw_np);
np = of_find_matching_node(fw_np, s10_of_match); np = of_find_matching_node(fw_np, s10_of_match);
if (!np) if (!np) {
of_node_put(fw_np);
return -ENODEV; return -ENODEV;
}
of_node_put(np); of_node_put(np);
ret = of_platform_populate(fw_np, s10_of_match, NULL, NULL); ret = of_platform_populate(fw_np, s10_of_match, NULL, NULL);
of_node_put(fw_np);
if (ret) if (ret)
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment