Commit f668f074 authored by Kevin Cernekee's avatar Kevin Cernekee Committed by Jason Cooper

irqchip: bcm7120-l2: Eliminate bad IRQ check

This check may be prone to race conditions, e.g.

1) Some external event (e.g. GPIO level) causes an IRQ to become pending
2) Peripheral asserts the L2 IRQ
3) CPU takes an interrupt
4) The event from #1 goes away
5) bcm7120_l2_intc_irq_handle() reads back a 0 status

Unlike the hardware supported by brcmstb-l2, the bcm7120-l2 controller
does not latch the IRQ status.  Bits can change if the inputs to the
controller change.  Also, do_bad_IRQ() is an ARM-specific macro.

So let's just nuke it.
Signed-off-by: default avatarKevin Cernekee <cernekee@gmail.com>
Acked-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Acked-by: default avatarArnd Bergmann <arnd@arndb.de>
Link: https://lkml.kernel.org/r/1415342669-30640-7-git-send-email-cernekee@gmail.comSigned-off-by: default avatarJason Cooper <jason@lakedaemon.net>
parent 05f12757
...@@ -27,8 +27,6 @@ ...@@ -27,8 +27,6 @@
#include "irqchip.h" #include "irqchip.h"
#include <asm/mach/irq.h>
/* Register offset in the L2 interrupt controller */ /* Register offset in the L2 interrupt controller */
#define IRQEN 0x00 #define IRQEN 0x00
#define IRQSTAT 0x04 #define IRQSTAT 0x04
...@@ -51,19 +49,12 @@ static void bcm7120_l2_intc_irq_handle(unsigned int irq, struct irq_desc *desc) ...@@ -51,19 +49,12 @@ static void bcm7120_l2_intc_irq_handle(unsigned int irq, struct irq_desc *desc)
chained_irq_enter(chip, desc); chained_irq_enter(chip, desc);
status = __raw_readl(b->base + IRQSTAT); status = __raw_readl(b->base + IRQSTAT);
while (status) {
if (status == 0) {
do_bad_IRQ(irq, desc);
goto out;
}
do {
irq = ffs(status) - 1; irq = ffs(status) - 1;
status &= ~(1 << irq); status &= ~(1 << irq);
generic_handle_irq(irq_find_mapping(b->domain, irq)); generic_handle_irq(irq_find_mapping(b->domain, irq));
} while (status); }
out:
chained_irq_exit(chip, desc); chained_irq_exit(chip, desc);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment