Commit f689c72d authored by NeilBrown's avatar NeilBrown Committed by Greg Kroah-Hartman

staging: lustre: statahead: remove incorrect test on agl_list_empty()

Including agl_list_empty() in the wait_event_idle() condition
is pointless as the body of the loop doesn't do anything
about the agl list.
So if the list wasn't empty, the while loop would spin
indefinitely.

The test was removed in the lustre-release commit
672ab0e00d61 ("LU-3270 statahead: small fixes and cleanup"),
but not in the Linux commit 5231f765 ("staging: lustre:
statahead: small fixes and cleanup").

Fixes: 5231f765 ("staging: lustre: statahead: small fixes and cleanup")
Signed-off-by: default avatarNeilBrown <neilb@suse.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2fab9faf
...@@ -1124,7 +1124,6 @@ static int ll_statahead_thread(void *arg) ...@@ -1124,7 +1124,6 @@ static int ll_statahead_thread(void *arg)
while (thread_is_running(sa_thread)) { while (thread_is_running(sa_thread)) {
wait_event_idle(sa_thread->t_ctl_waitq, wait_event_idle(sa_thread->t_ctl_waitq,
sa_has_callback(sai) || sa_has_callback(sai) ||
!agl_list_empty(sai) ||
!thread_is_running(sa_thread)); !thread_is_running(sa_thread));
sa_handle_callback(sai); sa_handle_callback(sai);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment