Commit f6b61541 authored by Nikita Shubin's avatar Nikita Shubin Committed by Bartosz Golaszewski

gpio: ep93xx: refactor ep93xx_gpio_add_bank

- replace plain numbers with girq->num_parents in devm_kcalloc
- replace plain numbers with girq->num_parents for port F
- refactor i - 1 to i + 1 to make loop more readable
- combine getting IRQ's loop and setting handler's into single loop
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Acked-by: default avatarAlexander Sverdlin <alexander.sverdlin@gmail.com>
Signed-off-by: default avatarNikita Shubin <nikita.shubin@maquefel.me>
Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
parent 78f85c73
...@@ -370,7 +370,7 @@ static int ep93xx_gpio_add_bank(struct ep93xx_gpio_chip *egc, ...@@ -370,7 +370,7 @@ static int ep93xx_gpio_add_bank(struct ep93xx_gpio_chip *egc,
girq->parent_handler = ep93xx_gpio_ab_irq_handler; girq->parent_handler = ep93xx_gpio_ab_irq_handler;
girq->num_parents = 1; girq->num_parents = 1;
girq->parents = devm_kcalloc(dev, 1, girq->parents = devm_kcalloc(dev, girq->num_parents,
sizeof(*girq->parents), sizeof(*girq->parents),
GFP_KERNEL); GFP_KERNEL);
if (!girq->parents) if (!girq->parents)
...@@ -392,15 +392,14 @@ static int ep93xx_gpio_add_bank(struct ep93xx_gpio_chip *egc, ...@@ -392,15 +392,14 @@ static int ep93xx_gpio_add_bank(struct ep93xx_gpio_chip *egc,
*/ */
girq->parent_handler = ep93xx_gpio_f_irq_handler; girq->parent_handler = ep93xx_gpio_f_irq_handler;
girq->num_parents = 8; girq->num_parents = 8;
girq->parents = devm_kcalloc(dev, 8, girq->parents = devm_kcalloc(dev, girq->num_parents,
sizeof(*girq->parents), sizeof(*girq->parents),
GFP_KERNEL); GFP_KERNEL);
if (!girq->parents) if (!girq->parents)
return -ENOMEM; return -ENOMEM;
/* Pick resources 1..8 for these IRQs */ /* Pick resources 1..8 for these IRQs */
for (i = 1; i <= 8; i++) for (i = 0; i < girq->num_parents; i++) {
girq->parents[i - 1] = platform_get_irq(pdev, i); girq->parents[i] = platform_get_irq(pdev, i + 1);
for (i = 0; i < 8; i++) {
gpio_irq = EP93XX_GPIO_F_IRQ_BASE + i; gpio_irq = EP93XX_GPIO_F_IRQ_BASE + i;
irq_set_chip_data(gpio_irq, &epg->gc[5]); irq_set_chip_data(gpio_irq, &epg->gc[5]);
irq_set_chip_and_handler(gpio_irq, irq_set_chip_and_handler(gpio_irq,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment