Commit f7b48cf0 authored by Eric Biggers's avatar Eric Biggers Committed by David Howells

KEYS: don't revoke uninstantiated key in request_key_auth_new()

If key_instantiate_and_link() were to fail (which fortunately isn't
possible currently), the call to key_revoke(authkey) would crash with a
NULL pointer dereference in request_key_auth_revoke() because the key
has not yet been instantiated.

Fix this by removing the call to key_revoke().  key_put() is sufficient,
as it's not possible for an uninstantiated authkey to have been used for
anything yet.

Fixes: b5f545c8 ("[PATCH] keys: Permit running process to instantiate keys")
Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
parent 44d81433
...@@ -220,7 +220,6 @@ struct key *request_key_auth_new(struct key *target, const void *callout_info, ...@@ -220,7 +220,6 @@ struct key *request_key_auth_new(struct key *target, const void *callout_info,
return authkey; return authkey;
error_put_authkey: error_put_authkey:
key_revoke(authkey);
key_put(authkey); key_put(authkey);
error_free_rka: error_free_rka:
free_request_key_auth(rka); free_request_key_auth(rka);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment