Commit f7d5ef0c authored by Liguang Zhang's avatar Liguang Zhang Committed by Catalin Marinas

firmware: arm_sdei: clean up sdei_event_create()

Function sdei_event_find() is always called in sdei_event_create(), but
it is already called in sdei_event_register(). This code is trying to
avoid a double-create of the same event, which can't happen as we still
hold the sdei_events_lock. We can remove this needless sdei_event_find()
call.
Signed-off-by: default avatarLiguang Zhang <zhangliguang@linux.alibaba.com>
[expanded commit message]
Signed-off-by: default avatarJames Morse <james.morse@arm.com>
Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
parent 54f529a6
...@@ -267,15 +267,9 @@ static struct sdei_event *sdei_event_create(u32 event_num, ...@@ -267,15 +267,9 @@ static struct sdei_event *sdei_event_create(u32 event_num,
event->private_registered = regs; event->private_registered = regs;
} }
if (sdei_event_find(event_num)) { spin_lock(&sdei_list_lock);
kfree(event->registered); list_add(&event->list, &sdei_list);
kfree(event); spin_unlock(&sdei_list_lock);
event = ERR_PTR(-EBUSY);
} else {
spin_lock(&sdei_list_lock);
list_add(&event->list, &sdei_list);
spin_unlock(&sdei_list_lock);
}
return event; return event;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment