Commit f8a70d8b authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

misc: vexpress: Off by one in vexpress_syscfg_exec()

The > comparison should be >= to prevent reading beyond the end of the
func->template[] array.

(The func->template array is allocated in vexpress_syscfg_regmap_init()
and it has func->num_templates elements.)

Fixes: 974cc7b9 ("mfd: vexpress: Define the device as MFD cells")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarSudeep Holla <sudeep.holla@arm.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b5058483
...@@ -61,7 +61,7 @@ static int vexpress_syscfg_exec(struct vexpress_syscfg_func *func, ...@@ -61,7 +61,7 @@ static int vexpress_syscfg_exec(struct vexpress_syscfg_func *func,
int tries; int tries;
long timeout; long timeout;
if (WARN_ON(index > func->num_templates)) if (WARN_ON(index >= func->num_templates))
return -EINVAL; return -EINVAL;
command = readl(syscfg->base + SYS_CFGCTRL); command = readl(syscfg->base + SYS_CFGCTRL);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment