Commit f8dbe58e authored by Christophe Roullier's avatar Christophe Roullier Committed by Paolo Abeni

net: stmmac: dwmac-stm32: update err status in case different of stm32mp13

The mask parameter of syscfg property is mandatory for MP13 but
optional for all other cases.
The function should not return error code because for non-MP13
the missing syscfg phandle in DT is not considered an error.
So reset err to 0 in that case to support existing DTs without
syscfg phandle.

Fixes: 50bbc039 ("net: stmmac: dwmac-stm32: add management of stm32mp13 for stm32")
Signed-off-by: default avatarChristophe Roullier <christophe.roullier@foss.st.com>
Reviewed-by: default avatarMarek Vasut <marex@denx.de>
Tested-by: default avatarMark Brown <broonie@kernel.org>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 3cd1d465
......@@ -435,10 +435,12 @@ static int stm32_dwmac_parse_data(struct stm32_dwmac *dwmac,
dwmac->mode_mask = SYSCFG_MP1_ETH_MASK;
err = of_property_read_u32_index(np, "st,syscon", 2, &dwmac->mode_mask);
if (err) {
if (dwmac->ops->is_mp13)
if (dwmac->ops->is_mp13) {
dev_err(dev, "Sysconfig register mask must be set (%d)\n", err);
else
} else {
dev_dbg(dev, "Warning sysconfig register mask not set\n");
err = 0;
}
}
return err;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment