Commit f950c600 authored by Yangtao Li's avatar Yangtao Li Committed by Stefan Bader

soc/tegra: Don't leak device tree node reference

BugLink: https://bugs.launchpad.net/bugs/1818813

[ Upstream commit 9eb40fa2 ]

of_find_node_by_path() acquires a reference to the node returned by it
and that reference needs to be dropped by its caller. soc_is_tegra()
doesn't do that, so fix it.
Signed-off-by: default avatarYangtao Li <tiny.windzz@gmail.com>
Acked-by: default avatarJon Hunter <jonathanh@nvidia.com>
[treding: slightly rewrite to avoid inline comparison]
Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarJuerg Haefliger <juergh@canonical.com>
Signed-off-by: default avatarKhalid Elmously <khalid.elmously@canonical.com>
parent dd5df9ce
...@@ -22,11 +22,15 @@ static const struct of_device_id tegra_machine_match[] = { ...@@ -22,11 +22,15 @@ static const struct of_device_id tegra_machine_match[] = {
bool soc_is_tegra(void) bool soc_is_tegra(void)
{ {
const struct of_device_id *match;
struct device_node *root; struct device_node *root;
root = of_find_node_by_path("/"); root = of_find_node_by_path("/");
if (!root) if (!root)
return false; return false;
return of_match_node(tegra_machine_match, root) != NULL; match = of_match_node(tegra_machine_match, root);
of_node_put(root);
return match != NULL;
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment