Commit f99e8f27 authored by Linus Torvalds's avatar Linus Torvalds

iSeries: Fix up viotty_ioctl BKL locking fallout

The bogus code to call into the n_tty layer got removed in commit
8bc5fb6a ("Remove bogons from the
iSeries console"), but it left a now uninitialized "return ret;" around.

Not that this code has ever even compiled since the BKL pushdown, since
not only is "ret" no longer initialized, it was never actually declared
even originally.

Replace it with a "return -ENOIOCTLCMD"
Pointed-out-by: default avatarPaul Mackerras <paulus@samba.org>
Acked-by: default avatarAlan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 680db013
......@@ -705,7 +705,7 @@ static int viotty_ioctl(struct tty_struct *tty, struct file *file,
case KDSKBLED:
return 0;
}
return ret;
return -ENOIOCTLCMD;
}
/*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment