Commit fa4b5ed6 authored by Andreas Kemnade's avatar Andreas Kemnade Committed by Kleber Sacilotto de Souza

power: supply: twl4030_charger: fix charging current out-of-bounds

BugLink: https://bugs.launchpad.net/bugs/1853881

[ Upstream commit 8314c212 ]

the charging current uses unsigned int variables, if we step back
if the current is still low, we would run into negative which
means setting the target to a huge value.
Better add checks here.
Signed-off-by: default avatarAndreas Kemnade <andreas@kemnade.info>
Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarConnor Kuehl <connor.kuehl@canonical.com>
Signed-off-by: default avatarKhalid Elmously <khalid.elmously@canonical.com>
parent c1022c4a
...@@ -449,7 +449,8 @@ static void twl4030_current_worker(struct work_struct *data) ...@@ -449,7 +449,8 @@ static void twl4030_current_worker(struct work_struct *data)
if (v < USB_MIN_VOLT) { if (v < USB_MIN_VOLT) {
/* Back up and stop adjusting. */ /* Back up and stop adjusting. */
bci->usb_cur -= USB_CUR_STEP; if (bci->usb_cur >= USB_CUR_STEP)
bci->usb_cur -= USB_CUR_STEP;
bci->usb_cur_target = bci->usb_cur; bci->usb_cur_target = bci->usb_cur;
} else if (bci->usb_cur >= bci->usb_cur_target || } else if (bci->usb_cur >= bci->usb_cur_target ||
bci->usb_cur + USB_CUR_STEP > USB_MAX_CURRENT) { bci->usb_cur + USB_CUR_STEP > USB_MAX_CURRENT) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment