Commit fa898d76 authored by David Ahern's avatar David Ahern Committed by Daniel Borkmann

bpf: Drop mpls from bpf_fib_lookup

MPLS support will not be submitted this dev cycle, but in working on it
I do see a few changes are needed to the API. For now, drop mpls from the
API. Since the fields in question are unions, the mpls fields can be added
back later without affecting the uapi.
Signed-off-by: default avatarDavid Ahern <dsahern@gmail.com>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
parent 720e7f38
...@@ -1852,10 +1852,10 @@ union bpf_attr { ...@@ -1852,10 +1852,10 @@ union bpf_attr {
* If lookup is successful and result shows packet is to be * If lookup is successful and result shows packet is to be
* forwarded, the neighbor tables are searched for the nexthop. * forwarded, the neighbor tables are searched for the nexthop.
* If successful (ie., FIB lookup shows forwarding and nexthop * If successful (ie., FIB lookup shows forwarding and nexthop
* is resolved), the nexthop address is returned in ipv4_dst, * is resolved), the nexthop address is returned in ipv4_dst
* ipv6_dst or mpls_out based on family, smac is set to mac * or ipv6_dst based on family, smac is set to mac address of
* address of egress device, dmac is set to nexthop mac address, * egress device, dmac is set to nexthop mac address, rt_metric
* rt_metric is set to metric from route. * is set to metric from route (IPv4/IPv6 only).
* *
* *plen* argument is the size of the passed in struct. * *plen* argument is the size of the passed in struct.
* *flags* argument can be a combination of one or more of the * *flags* argument can be a combination of one or more of the
...@@ -2537,8 +2537,10 @@ struct bpf_raw_tracepoint_args { ...@@ -2537,8 +2537,10 @@ struct bpf_raw_tracepoint_args {
#define BPF_FIB_LOOKUP_OUTPUT BIT(1) #define BPF_FIB_LOOKUP_OUTPUT BIT(1)
struct bpf_fib_lookup { struct bpf_fib_lookup {
/* input */ /* input: network family for lookup (AF_INET, AF_INET6)
__u8 family; /* network family, AF_INET, AF_INET6, AF_MPLS */ * output: network family of egress nexthop
*/
__u8 family;
/* set if lookup is to consider L4 data - e.g., FIB rules */ /* set if lookup is to consider L4 data - e.g., FIB rules */
__u8 l4_protocol; __u8 l4_protocol;
...@@ -2554,22 +2556,20 @@ struct bpf_fib_lookup { ...@@ -2554,22 +2556,20 @@ struct bpf_fib_lookup {
__u8 tos; /* AF_INET */ __u8 tos; /* AF_INET */
__be32 flowlabel; /* AF_INET6 */ __be32 flowlabel; /* AF_INET6 */
/* output: metric of fib result */ /* output: metric of fib result (IPv4/IPv6 only) */
__u32 rt_metric; __u32 rt_metric;
}; };
union { union {
__be32 mpls_in;
__be32 ipv4_src; __be32 ipv4_src;
__u32 ipv6_src[4]; /* in6_addr; network order */ __u32 ipv6_src[4]; /* in6_addr; network order */
}; };
/* input to bpf_fib_lookup, *dst is destination address. /* input to bpf_fib_lookup, ipv{4,6}_dst is destination address in
* output: bpf_fib_lookup sets to gateway address * network header. output: bpf_fib_lookup sets to gateway address
* if FIB lookup returns gateway route
*/ */
union { union {
/* return for MPLS lookups */
__be32 mpls_out[4]; /* support up to 4 labels */
__be32 ipv4_dst; __be32 ipv4_dst;
__u32 ipv6_dst[4]; /* in6_addr; network order */ __u32 ipv6_dst[4]; /* in6_addr; network order */
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment