Commit fbae30d8 authored by Chanwoo Choi's avatar Chanwoo Choi

extcon: sm5502: Clean up codes by using checkpatch script

This patch just clean up codes by using checkpatch script and fix warning
message about if statement.

- the result of checkpatch script as following:
WARNING: void function return statements are not generally useful
+	return;
+}

WARNING: quoted string split across lines
+			dev_err(info->dev, "failed: irq request (IRQ: %d,"
+				" error :%d)\n", muic_irq->irq, ret);

- warning message about coding style.

	drivers/extcon/extcon-sm5502.c:398 sm5502_muic_cable_handler()
		warn: we tested 'attached' before and it was 'false'
Signed-off-by: default avatarChanwoo Choi <cw00.choi@samsung.com>
parent ca2a07e4
...@@ -391,7 +391,7 @@ static int sm5502_muic_cable_handler(struct sm5502_muic_info *info, ...@@ -391,7 +391,7 @@ static int sm5502_muic_cable_handler(struct sm5502_muic_info *info,
/* Get the type of attached or detached cable */ /* Get the type of attached or detached cable */
if (attached) if (attached)
cable_type = sm5502_muic_get_cable_type(info); cable_type = sm5502_muic_get_cable_type(info);
else if (!attached) else
cable_type = prev_cable_type; cable_type = prev_cable_type;
prev_cable_type = cable_type; prev_cable_type = cable_type;
...@@ -453,8 +453,6 @@ static void sm5502_muic_irq_work(struct work_struct *work) ...@@ -453,8 +453,6 @@ static void sm5502_muic_irq_work(struct work_struct *work)
dev_err(info->dev, "failed to handle MUIC interrupt\n"); dev_err(info->dev, "failed to handle MUIC interrupt\n");
mutex_unlock(&info->mutex); mutex_unlock(&info->mutex);
return;
} }
/* /*
...@@ -613,8 +611,9 @@ static int sm5022_muic_i2c_probe(struct i2c_client *i2c, ...@@ -613,8 +611,9 @@ static int sm5022_muic_i2c_probe(struct i2c_client *i2c,
IRQF_NO_SUSPEND, IRQF_NO_SUSPEND,
muic_irq->name, info); muic_irq->name, info);
if (ret) { if (ret) {
dev_err(info->dev, "failed: irq request (IRQ: %d," dev_err(info->dev,
" error :%d)\n", muic_irq->irq, ret); "failed: irq request (IRQ: %d, error :%d)\n",
muic_irq->irq, ret);
return ret; return ret;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment